From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.axis.com (smtp1.axis.com [195.60.68.17]) by sourceware.org (Postfix) with ESMTPS id 299103858023 for ; Tue, 7 Sep 2021 20:41:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 299103858023 From: Hans-Peter Nilsson To: In-Reply-To: (message from Martin Liaka on Wed, 18 Aug 2021 10:38:26 +0200) Subject: [Committed] Fix fatal typo in gcc.dg/no_profile_instrument_function-attr-2.c MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT References: <4a46257d-91cd-427e-1b11-7599ad36d07f@suse.cz> <20210623123841.GC65660@kam.mff.cuni.cz> <7fed627d-7213-918c-3ca6-0db60623a32b@suse.cz> Message-ID: <20210907204154.9F4CB203AE@pchp3.se.axis.com> Date: Tue, 7 Sep 2021 22:41:54 +0200 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Sep 2021 20:41:59 -0000 (Committed as obvious.) Dejagnu is unfortunately brittle: a syntax error in a directive can abort the test-run for the current "tool" (gcc, g++, gfortran), and if you don't check for this condition or actually read the stdout log yourself, your tools may make you believe the test was successful without regressions. At the very least, always grep for ^ERROR: in the stdout log! With r12-3379, the testsuite got such a fatal syntax error, causing the gcc test-run to abort at (e.g.): ... FAIL: gcc.dg/memchr.c (test for excess errors) FAIL: gcc.dg/memcmp-3.c (test for excess errors) ERROR: (DejaGnu) proc "scan-tree-dump-not\" = foo {\(\)"} optimized" does not exist. The error code is TCL LOOKUP COMMAND scan-tree-dump-not\" The info on the error is: invalid command name "scan-tree-dump-not"" while executing "::tcl_unknown scan-tree-dump-not\" = foo {\(\)"} optimized" ("uplevel" body line 1) invoked from within "uplevel 1 ::tcl_unknown $args" === gcc Summary === # of expected passes 63740 # of unexpected failures 38 # of unexpected successes 2 # of expected failures 351 # of unresolved testcases 3 # of unsupported tests 662 x/cris-elf/gccobj/gcc/xgcc version 12.0.0 20210907 (experimental)\ [master r12-3391-g849d5f5929fc] (GCC) testsuite: * gcc.dg/no_profile_instrument_function-attr-2.c: Fix typo in last change. --- gcc/testsuite/gcc.dg/no_profile_instrument_function-attr-2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/testsuite/gcc.dg/no_profile_instrument_function-attr-2.c b/gcc/testsuite/gcc.dg/no_profile_instrument_function-attr-2.c index 472eca88efdd..2e93ee5f6891 100644 --- a/gcc/testsuite/gcc.dg/no_profile_instrument_function-attr-2.c +++ b/gcc/testsuite/gcc.dg/no_profile_instrument_function-attr-2.c @@ -12,4 +12,4 @@ int bar() return foo(); } -/* { dg-final { scan-tree-dump-not" = foo \\(\\)" "optimized"} } */ +/* { dg-final { scan-tree-dump-not " = foo \\(\\)" "optimized"} } */ -- 2.11.0