From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id BB8723858407 for ; Wed, 8 Sep 2021 09:09:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BB8723858407 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-106-v0Ubzpm9N_KcUjqd8FpJAA-1; Wed, 08 Sep 2021 05:09:44 -0400 X-MC-Unique: v0Ubzpm9N_KcUjqd8FpJAA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EA460824FA6; Wed, 8 Sep 2021 09:09:42 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.10]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 43D3D1002391; Wed, 8 Sep 2021 09:09:42 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 18899ead1503395 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 8 Sep 2021 11:09:40 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 18899a4W1503394; Wed, 8 Sep 2021 11:09:36 +0200 Date: Wed, 8 Sep 2021 11:09:36 +0200 From: Jakub Jelinek To: Hongtao Liu Cc: Uros Bizjak , Richard Biener , Iain Sandoe , GCC Patches , liuhongt , Joseph Myers Subject: Re: [PATCH] libgcc, i386: Export *hf* and *hc* from libgcc_s.so.1 Message-ID: <20210908090936.GQ920497@tucnak> Reply-To: Jakub Jelinek References: <20210903074113.39461-1-hongtao.liu@intel.com> <20210903090036.GX920497@tucnak> <20210906070855.GL920497@tucnak> <92E99F52-C804-4F37-870F-C559A46A8C38@googlemail.com> <20210906085853.GP920497@tucnak> <20210907122829.GJ920497@tucnak> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Sep 2021 09:09:49 -0000 On Wed, Sep 08, 2021 at 10:37:17AM +0800, Hongtao Liu wrote: > Bootstrapped and regtested on x86_64-linux-gnu{-m32,}. > Ok for trunk? > > libgcc/ChangeLog: > > * config/i386/t-softfp: Compile __{mul,div}hc3 into > libgcc_s.so.1. I think this is ok, but not really useful until the *.ver change is acked, because what this patch alone does is add extra non-exported entrypoints to the shared library (aka wasted .text). > libgcc/config/i386/t-softfp | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libgcc/config/i386/t-softfp b/libgcc/config/i386/t-softfp > index 2363ea17194..7620cc0cec5 100644 > --- a/libgcc/config/i386/t-softfp > +++ b/libgcc/config/i386/t-softfp > @@ -2,9 +2,8 @@ LIB2ADD += $(srcdir)/config/i386/sfp-exceptions.c > > # Replace _divhc3 and _mulhc3. > libgcc2-hf-functions = _divhc3 _mulhc3 > -LIB2FUNCS_EXCLUDE += $(libgcc2-hf-functions) > libgcc2-hf-extras = $(addsuffix .c, $(libgcc2-hf-functions)) > -LIB2ADD_ST += $(addprefix $(srcdir)/config/i386/, $(libgcc2-hf-extras)) > +LIB2ADD += $(addprefix $(srcdir)/config/i386/, $(libgcc2-hf-extras)) > > softfp_extensions := hfsf hfdf hftf hfxf sfdf sftf dftf xftf > softfp_truncations := tfhf xfhf dfhf sfhf tfsf dfsf tfdf tfxf Jakub