From: Hans-Peter Nilsson <hp@axis.com>
To: Martin Liaka <mliska@suse.cz>
Cc: <gcc-patches@gcc.gnu.org>
Subject: Re: [Committed] Fix fatal typo in gcc.dg/no_profile_instrument_function-attr-2.c
Date: Wed, 8 Sep 2021 13:25:14 +0200 [thread overview]
Message-ID: <20210908112514.2897B203AE@pchp3.se.axis.com> (raw)
In-Reply-To: <0f3a38aa-66bd-7c52-72fa-b15666a6ff98@suse.cz> (message from Martin Liaka on Wed, 8 Sep 2021 09:29:52 +0200)
> From: Martin Liaka <mliska@suse.cz>
> Date: Wed, 8 Sep 2021 09:29:52 +0200
> On 9/7/21 22:41, Hans-Peter Nilsson wrote:
> > With r12-3379, the testsuite got such a fatal syntax error,
> > causing the gcc test-run to abort at (e.g.):
>
> Thank you for the fix! I haven't noticed the problem as I only grep for '^FAIL'
> lines in the corresponding log files.
You're welcome but *please* also add (conceptually)
"grep -q ^ERROR: makelog && fail" to your workflow.
brgds, H-P
PS. yeah, but worth repeating
next prev parent reply other threads:[~2021-09-08 11:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 11:53 [PATCH] inline: do not inline when no_profile_instrument_function is different Martin Liška
2021-06-23 12:38 ` Jan Hubicka
2021-06-23 13:15 ` Martin Liška
2021-06-25 19:00 ` Nick Desaulniers
2021-08-18 8:38 ` Martin Liška
2021-09-06 17:06 ` Jeff Law
2021-09-07 20:41 ` [Committed] Fix fatal typo in gcc.dg/no_profile_instrument_function-attr-2.c Hans-Peter Nilsson
2021-09-08 7:29 ` Martin Liška
2021-09-08 11:25 ` Hans-Peter Nilsson [this message]
2021-09-08 11:31 ` Rainer Orth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210908112514.2897B203AE@pchp3.se.axis.com \
--to=hp@axis.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).