From: Jakub Jelinek <jakub@redhat.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: testsuite: Allow .sdata in more cases in gcc.dg/array-quals-1.c
Date: Wed, 8 Sep 2021 17:28:53 +0200 [thread overview]
Message-ID: <20210908152853.GV920497@tucnak> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2109081524230.30467@digraph.polyomino.org.uk>
On Wed, Sep 08, 2021 at 03:25:24PM +0000, Joseph Myers wrote:
> When testing for Nios II (gcc-testresults shows this for MIPS as
> well), failures of gcc.dg/array-quals-1.c appear where a symbol was
> found in .sdata rather than one of the expected sections.
>
> FAIL: gcc.dg/array-quals-1.c scan-assembler-symbol-section symbol ^_?a$ (found a) has section ^\\.(const|rodata|srodata)|\\[RO\\] (found .sdata)
> FAIL: gcc.dg/array-quals-1.c scan-assembler-symbol-section symbol ^_?b$ (found b) has section ^\\.(const|rodata|srodata)|\\[RO\\] (found .sdata)
> FAIL: gcc.dg/array-quals-1.c scan-assembler-symbol-section symbol ^_?c$ (found c) has section ^\\.(const|rodata|srodata)|\\[RO\\] (found .sdata)
> FAIL: gcc.dg/array-quals-1.c scan-assembler-symbol-section symbol ^_?d$ (found d) has section ^\\.(const|rodata|srodata)|\\[RO\\] (found .sdata)
>
> Jakub's commit 0b34dbc0a24864b1674bff7a92fa3cf0f1cbcea1 allowed .sdata
> for many variables in that test where use of .sdata caused a failure
> on powerpc-linux. I'm presuming the choice of which variables had
> .sdata allowed was based only on the code generated for powerpc-linux,
> not on any reason it would be wrong to allow it for the other
Yeah.
> variables; thus, this patch adjusts the test to allow .sdata for some
> more variables where that is needed on Nios II (and in one case where
> it's not needed on Nios II, but the test results on gcc-testresults
> suggest that it is needed on MIPS).
>
> Tested with no regressions with cross to nios2-elf. OK to commit?
>
> * gcc.dg/array-quals-1.c: Allow .sdata section in more cases.
LGTM.
Jakub
prev parent reply other threads:[~2021-09-08 15:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 15:25 Joseph Myers
2021-09-08 15:28 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210908152853.GV920497@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).