From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by sourceware.org (Postfix) with ESMTPS id F1347384A8AB for ; Fri, 10 Sep 2021 12:58:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F1347384A8AB X-IronPort-AV: E=McAfee;i="6200,9189,10102"; a="219208752" X-IronPort-AV: E=Sophos;i="5.85,282,1624345200"; d="scan'208";a="219208752" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2021 05:58:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,282,1624345200"; d="scan'208";a="514285900" Received: from scymds01.sc.intel.com ([10.148.94.138]) by orsmga001.jf.intel.com with ESMTP; 10 Sep 2021 05:58:27 -0700 Received: from shliclel219.sh.intel.com (shliclel219.sh.intel.com [10.239.236.219]) by scymds01.sc.intel.com with ESMTP id 18ACwIBv025632; Fri, 10 Sep 2021 05:58:25 -0700 From: liuhongt To: gcc-patches@gcc.gnu.org Cc: meissner@linux.ibm.com, segher@kernel.crashing.org, richard.guenther@gmail.com, jimw@sifive.com, schwab@linux-m68k.org, andrew@sifive.com, asolokha@gmx.com Subject: [PATCH 2/2] validate_subreg before call gen_lowpart to avoid ICE. Date: Fri, 10 Sep 2021 20:58:18 +0800 Message-Id: <20210910125818.334531-3-hongtao.liu@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210910125818.334531-1-hongtao.liu@intel.com> References: <20210910125818.334531-1-hongtao.liu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_NONE, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Sep 2021 12:58:29 -0000 gcc/ChangeLog: * expmed.c (extract_bit_field_using_extv): validate_subreg before call gen_lowpart. --- gcc/expmed.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/gcc/expmed.c b/gcc/expmed.c index 3143f38e057..10d62d857a8 100644 --- a/gcc/expmed.c +++ b/gcc/expmed.c @@ -1571,12 +1571,16 @@ extract_bit_field_using_extv (const extraction_insn *extv, rtx op0, if (GET_MODE (target) != ext_mode) { + machine_mode tmode = GET_MODE (target); /* Don't use LHS paradoxical subreg if explicit truncation is needed between the mode of the extraction (word_mode) and the target mode. Instead, create a temporary and use convert_move to set the target. */ if (REG_P (target) - && TRULY_NOOP_TRUNCATION_MODES_P (GET_MODE (target), ext_mode)) + && TRULY_NOOP_TRUNCATION_MODES_P (tmode, ext_mode) + && validate_subreg (ext_mode, tmode, + target, + subreg_lowpart_offset (ext_mode, tmode))) { target = gen_lowpart (ext_mode, target); if (partial_subreg_p (GET_MODE (spec_target), ext_mode)) -- 2.27.0