public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Richard Biener <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] middle-end/102360 - adjust .DEFERRED_INIT expansion
Date: Thu, 16 Sep 2021 12:26:12 +0200	[thread overview]
Message-ID: <20210916102612.GG304296@tucnak> (raw)
In-Reply-To: <98o56o49-7r8r-s95q-83o5-n7o8ss4ppnpq@fhfr.qr>

On Thu, Sep 16, 2021 at 11:48:49AM +0200, Richard Biener via Gcc-patches wrote:
> 2021-09-16  Richard Biener  <rguenther@suse.de>
> 
> 	PR middle-end/102360
> 	* internal-fn.c (expand_DEFERRED_INIT): Make pattern-init
> 	of non-memory more robust.
> 
> 	* g++.dg/pr102360.C: New testcase.
> +	  if (can_native_interpret_type_p (var_type))
> +	    init = native_interpret_expr (var_type, buf, total_bytes);
> +	  else
> +	    {
> +	      tree itype = build_nonstandard_integer_type (total_bytes * 8, 1);

Shouldn't that 8 be BITS_PER_UNIT ?
I know we have tons of problems with BITS_PER_UNIT is not 8, but adding
further ones is unnecessary.

	Jakub


  reply	other threads:[~2021-09-16 10:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-16  9:48 Richard Biener
2021-09-16 10:26 ` Jakub Jelinek [this message]
2021-09-16 10:41   ` Richard Biener
2021-09-16 10:51     ` Jakub Jelinek
2021-09-16 10:59       ` Richard Biener
2021-09-16 15:22         ` Michael Matz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210916102612.GG304296@tucnak \
    --to=jakub@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).