From: Pierre-Marie de Rodat <derodat@adacore.com>
To: gcc-patches@gcc.gnu.org
Cc: Piotr Trojanek <trojanek@adacore.com>
Subject: [Ada] Update comment for Error_Msg_Internal
Date: Tue, 21 Sep 2021 15:26:01 +0000 [thread overview]
Message-ID: <20210921152601.GA3094541@adacore.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 318 bytes --]
When Error_Msg_Internal parameters Sptr and Optr were renamed to Span
and Opan, its comment has not been updated.
Tested on x86_64-pc-linux-gnu, committed on trunk
gcc/ada/
* errout.adb (Error_Msg_Internal): Fix references to Sptr and
Optr in comment; fix grammar of "low-level" where it is used as
an adjective.
[-- Attachment #2: patch.diff --]
[-- Type: text/x-diff, Size: 1541 bytes --]
diff --git a/gcc/ada/errout.adb b/gcc/ada/errout.adb
--- a/gcc/ada/errout.adb
+++ b/gcc/ada/errout.adb
@@ -106,15 +106,15 @@ package body Errout is
Opan : Source_Span;
Msg_Cont : Boolean;
Node : Node_Id);
- -- This is the low level routine used to post messages after dealing with
+ -- This is the low-level routine used to post messages after dealing with
-- the issue of messages placed on instantiations (which get broken up
- -- into separate calls in Error_Msg). Sptr is the location on which the
+ -- into separate calls in Error_Msg). Span is the location on which the
-- flag will be placed in the output. In the case where the flag is on
-- the template, this points directly to the template, not to one of the
- -- instantiation copies of the template. Optr is the original location
+ -- instantiation copies of the template. Opan is the original location
-- used to flag the error, and this may indeed point to an instantiation
- -- copy. So typically we can see Optr pointing to the template location
- -- in an instantiation copy when Sptr points to the source location of
+ -- copy. So typically we can see Opan pointing to the template location
+ -- in an instantiation copy when Span points to the source location of
-- the actual instantiation (i.e the line with the new). Msg_Cont is
-- set true if this is a continuation message. Node is the relevant
-- Node_Id for this message, to be used to compute the enclosing entity if
reply other threads:[~2021-09-21 15:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210921152601.GA3094541@adacore.com \
--to=derodat@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=trojanek@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).