From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id DDB263858421 for ; Wed, 29 Sep 2021 08:07:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DDB263858421 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-558-t_EM9vJtNHiiBSRiJvyI7A-1; Wed, 29 Sep 2021 04:07:31 -0400 X-MC-Unique: t_EM9vJtNHiiBSRiJvyI7A-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 55BE9835DE7 for ; Wed, 29 Sep 2021 08:07:30 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.193.109]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E33385D9C6; Wed, 29 Sep 2021 08:07:27 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 18T87LgN356338 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 29 Sep 2021 10:07:23 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 18T876LT356251; Wed, 29 Sep 2021 10:07:06 +0200 Date: Wed, 29 Sep 2021 10:07:06 +0200 From: Jakub Jelinek To: Jason Merrill , gcc-patches@gcc.gnu.org Subject: Re: [PATCH, v2] c++: Fix up synthetization of defaulted comparison operators on classes with bitfields [PR102490] Message-ID: <20210929080706.GJ304296@tucnak> Reply-To: Jakub Jelinek References: <20210928092455.GU304296@tucnak> <742e6e4c-f921-e12-ccc0-edc6ca19f99@idea> <28ed21ef-fac2-8e93-44f4-f2b5ab287621@idea> <38a8c792-f599-5802-ffe3-a43eaee81479@redhat.com> <20210928203439.GG304296@tucnak> MIME-Version: 1.0 In-Reply-To: <20210928203439.GG304296@tucnak> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Sep 2021 08:07:34 -0000 On Tue, Sep 28, 2021 at 10:34:39PM +0200, Jakub Jelinek via Gcc-patches wrote: > On Tue, Sep 28, 2021 at 03:33:35PM -0400, Jason Merrill wrote: > > > > According to the function comment for defaulted_late_check, won't > > > > COMPLETE_TYPE_P (ctx) always be false here? > > > > Not for a function defaulted outside the class. > > > > > If so, I wonder if we could get away with moving this entire fragment > > > from defaulted_late_check to finish_struct_1 instead of calling > > > defaulted_late_check from finish_struct_1. > > > > The comment in check_bases_and_members says that we call it there so that > > it's before we clone [cd]tors. Probably better to leave the call there for > > other functions, just skip it for comparisons. > > So like this instead then? Just tested with dg.exp=*spaceship* so far. > > 2021-09-28 Jakub Jelinek > > PR c++/102490 > * method.c (defaulted_late_check): Don't synthetize constexpr > defaulted comparisons. > (finish_struct_1): Synthetize constexpr defaulted comparisons here > after layout_class_type. > > * g++.dg/cpp2a/spaceship-eq11.C: New test. > * g++.dg/cpp2a/spaceship-eq12.C: New test. Also successfully bootstrapped/regtested on x86_64-linux and i686-linux. Jakub