From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ciao.gmane.io (ciao.gmane.io [116.202.254.214]) by sourceware.org (Postfix) with ESMTPS id 4B83E3858024 for ; Fri, 1 Oct 2021 17:16:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4B83E3858024 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=m.gmane-mx.org Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1mWM9H-0006ML-KS for gcc-patches@gcc.gnu.org; Fri, 01 Oct 2021 19:16:39 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: gcc-patches@gcc.gnu.org From: Julian Brown Subject: Re: [PATCH 05/11] OpenMP/OpenACC: Hoist struct sibling list handling in gimplification Date: Fri, 1 Oct 2021 18:16:25 +0100 Organization: Siemens Message-ID: <20211001181625.4b6cd79d@squid.athome> References: <00411b16d398cb33a52f4357a527adf4bca4a94d.1633106213.git.julian@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Jakub Jelinek , Thomas Schwinge , cltang@codesourcery.com In-Reply-To: <00411b16d398cb33a52f4357a527adf4bca4a94d.1633106213.git.julian@codesourcery.com> X-Newsreader: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Oct 2021 17:16:43 -0000 Oops, editing: On Fri, 1 Oct 2021 10:09:03 -0700 Julian Brown wrote: > Secondly, it means that in the first pass gathering up sibling lists > from parsed OpenMP/OpenACC clauses, we don't need to worry about > gimplifying: that means we can see struct bases & components we need > to sort sibling lists properly, even when we're using a non-DECL_P > struct base. Gimplification proper still happens ...in the main loop in gimplify_scan_omp_clauses.