From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 7D16E3858D28 for ; Mon, 11 Oct 2021 09:29:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7D16E3858D28 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-595-GkPo47AZNxCEzSE0v954Fg-1; Mon, 11 Oct 2021 05:29:06 -0400 X-MC-Unique: GkPo47AZNxCEzSE0v954Fg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C83C4835DE2; Mon, 11 Oct 2021 09:29:05 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.193.109]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 63D0B4180; Mon, 11 Oct 2021 09:29:05 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 19B9T21W3923295 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 11 Oct 2021 11:29:02 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 19B9SuiL3923294; Mon, 11 Oct 2021 11:28:56 +0200 Date: Mon, 11 Oct 2021 11:28:55 +0200 From: Jakub Jelinek To: liuhongt , Richard Biener Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Adjust more testcases for O2 vectorization enabling. Message-ID: <20211011092855.GQ304296@tucnak> Reply-To: Jakub Jelinek References: <20211009045515.54589-1-hongtao.liu@intel.com> MIME-Version: 1.0 In-Reply-To: <20211009045515.54589-1-hongtao.liu@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Oct 2021 09:29:09 -0000 On Sat, Oct 09, 2021 at 12:55:15PM +0800, liuhongt via Gcc-patches wrote: > Pushed to trunk. > > libgomp/ChangeLog: > > * testsuite/libgomp.c++/scan-10.C: Add option -fvect-cost-model=cheap. > * testsuite/libgomp.c++/scan-11.C: Ditto. > * testsuite/libgomp.c++/scan-12.C: Ditto. > * testsuite/libgomp.c++/scan-13.C: Ditto. > * testsuite/libgomp.c++/scan-14.C: Ditto. > * testsuite/libgomp.c++/scan-15.C: Ditto. > * testsuite/libgomp.c++/scan-16.C: Ditto. > * testsuite/libgomp.c++/scan-9.C: Ditto. > * testsuite/libgomp.c-c++-common/lastprivate-conditional-7.c: Ditto. > * testsuite/libgomp.c-c++-common/lastprivate-conditional-8.c: Ditto. > * testsuite/libgomp.c/scan-11.c: Ditto. > * testsuite/libgomp.c/scan-12.c: Ditto. > * testsuite/libgomp.c/scan-13.c: Ditto. > * testsuite/libgomp.c/scan-14.c: Ditto. > * testsuite/libgomp.c/scan-15.c: Ditto. > * testsuite/libgomp.c/scan-16.c: Ditto. > * testsuite/libgomp.c/scan-17.c: Ditto. > * testsuite/libgomp.c/scan-18.c: Ditto. > * testsuite/libgomp.c/scan-19.c: Ditto. > * testsuite/libgomp.c/scan-20.c: Ditto. > * testsuite/libgomp.c/scan-21.c: Ditto. > * testsuite/libgomp.c/scan-22.c: Ditto. I don't think this is the right thing to do. This just means that at some point between 2013 when -fsimd-cost-model has been introduced and now -fsimd-cost-model= option at least partially stopped working properly. As documented, -fsimd-cost-model= overrides the -fvect-cost-model= setting for OpenMP simd loops (loop->force_vectorize is true) if specified differently from default. In tree-vectorizer.h we have: static inline bool unlimited_cost_model (loop_p loop) { if (loop != NULL && loop->force_vectorize && flag_simd_cost_model != VECT_COST_MODEL_DEFAULT) return flag_simd_cost_model == VECT_COST_MODEL_UNLIMITED; return (flag_vect_cost_model == VECT_COST_MODEL_UNLIMITED); } and use it in various places, but we also just use flag_vect_cost_model in lots of places (and in one spot use flag_simd_cost_model, not sure if we are sure it is a force_vectorize loop or what). So, IMHO we should change the above inline function to loop_cost_model and let it return the cost model and then just reimplement unlimited_cost_model as return loop_cost_model (loop) == VECT_COST_MODEL_UNLIMITED; and then adjust the direct uses of the flag and revert these changes. Jakub