From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id 188B13857408 for ; Tue, 12 Oct 2021 16:20:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 188B13857408 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 19CGIeMA018762; Tue, 12 Oct 2021 11:18:55 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 19CGIOtG018746; Tue, 12 Oct 2021 11:18:24 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Tue, 12 Oct 2021 11:18:18 -0500 From: Segher Boessenkool To: Martin Sebor Cc: Hongtao Liu , Hongtao Liu , GCC Patches , Bill Schmidt , David Edelsohn Subject: Re: [PATCH] rs6000/test: Adjust some cases due to O2 vect [PR102658] Message-ID: <20211012161818.GH10333@gate.crashing.org> References: <0e964ac9-0e58-33c1-c0ab-24b7f1c60be3@linux.ibm.com> <20211011153050.GV10333@gate.crashing.org> <9bb2743f-cd23-5b7d-6d9d-9917e591377f@gmail.com> <20211011174302.GZ10333@gate.crashing.org> <5966f37c-a51e-593c-4ee2-05c3d04c89fc@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5966f37c-a51e-593c-4ee2-05c3d04c89fc@gmail.com> User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Oct 2021 16:20:52 -0000 Hi! On Tue, Oct 12, 2021 at 09:49:19AM -0600, Martin Sebor wrote: > Coming back to the xfail conditionals, do you think you'll > be able to put together some target-supports magic so they > don't have to enumerate all the affected targets? There should only be an xfail if we do not expect to be able to fix the bug causing this any time soon. There shouldn't be one here, not yet anyway. Other than that: yes, and one you have such a selector, just dg-require it (or its inverse) for this test, don't xfail the test (if this is expected and correct behaviour). Segher