From: Segher Boessenkool <segher@kernel.crashing.org>
To: HAO CHEN GUI <guihaoc@linux.ibm.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
Bill Schmidt <wschmidt@linux.ibm.com>
Subject: Re: [PATCH, rs6000] Disable gimple fold for float or double vec_minmax when fast-math is not set
Date: Wed, 13 Oct 2021 13:28:59 -0500 [thread overview]
Message-ID: <20211013182859.GB614@gate.crashing.org> (raw)
In-Reply-To: <d98a12d0-6089-315d-9264-62260ec85530@linux.ibm.com>
On Tue, Oct 12, 2021 at 04:57:43PM +0800, HAO CHEN GUI wrote:
> b/gcc/config/rs6000/rs6000-call.c
> index b4e13af4dc6..90527734ceb 100644
> --- a/gcc/config/rs6000/rs6000-call.c
> +++ b/gcc/config/rs6000/rs6000-call.c
> @@ -12159,6 +12159,11 @@ rs6000_gimple_fold_builtin (gimple_stmt_iterator
> *gsi)
> return true;
> /* flavors of vec_min. */
> case VSX_BUILTIN_XVMINDP:
> + case ALTIVEC_BUILTIN_VMINFP:
> + if (!flag_finite_math_only || flag_signed_zeros)
> + return false;
> + /* Fall through to MIN_EXPR. */
> + gcc_fallthrough ();
> case P8V_BUILTIN_VMINSD:
> case P8V_BUILTIN_VMINUD:
> case ALTIVEC_BUILTIN_VMINSB:
"Fall though to code for MIN_EXPR"? It suggests it is a label, as
written now. Or don't have this comment at all, maybe?
> +/* { dg-do compile { target { powerpc*-*-* } } } */
Leave out the target clause? Testcases in gcc.target/powerpc/ are not
run when this is not satisfied anyway, testing it twice is just more
noise.
Segher
next prev parent reply other threads:[~2021-10-13 18:30 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 8:57 HAO CHEN GUI
2021-10-12 9:57 ` Richard Biener
2021-10-13 7:43 ` HAO CHEN GUI
2021-10-13 8:29 ` Richard Biener
2021-10-13 9:15 ` HAO CHEN GUI
2021-10-13 18:19 ` Segher Boessenkool
2021-10-13 22:04 ` Joseph Myers
2021-10-13 18:28 ` Segher Boessenkool [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-11-01 6:48 HAO CHEN GUI
2021-11-02 0:21 ` David Edelsohn
2021-11-02 2:40 ` HAO CHEN GUI
2021-11-02 13:12 ` David Edelsohn
2021-11-03 2:14 ` HAO CHEN GUI
2021-10-20 9:04 HAO CHEN GUI
2021-10-20 16:19 ` Segher Boessenkool
2021-10-21 6:25 ` HAO CHEN GUI
2021-10-13 15:02 David Edelsohn
2021-08-24 8:52 HAO CHEN GUI
2021-08-24 20:04 ` Bill Schmidt
2021-08-24 22:40 ` Segher Boessenkool
2021-08-25 7:06 ` HAO CHEN GUI
2021-08-25 7:50 ` Kewen.Lin
2021-08-25 8:17 ` HAO CHEN GUI
2021-08-25 8:44 ` HAO CHEN GUI
2021-08-25 12:34 ` Bill Schmidt
2021-08-26 1:19 ` HAO CHEN GUI
2021-09-06 6:01 ` HAO CHEN GUI
2021-10-11 15:55 ` Segher Boessenkool
2021-10-11 16:07 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211013182859.GB614@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=guihaoc@linux.ibm.com \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).