public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Aldy Hernandez <aldyh@redhat.com>
To: GCC patches <gcc-patches@gcc.gnu.org>
Subject: [COMMITTED] Make signness explicit in tree-ssa/pr102736.c
Date: Fri, 15 Oct 2021 12:57:39 +0200	[thread overview]
Message-ID: <20211015105740.267657-1-aldyh@redhat.com> (raw)

This test is failing on ppc64* due to different default signness for
chars.  Thanks to Richi for quickly pointing out the problem.

Tested on x86-64 Linux and ppc64le Linux.

gcc/testsuite/ChangeLog:

	PR testsuite/pr102751
	* gcc.dg/tree-ssa/pr102736.c: Make sign explicit.
---
 gcc/testsuite/gcc.dg/tree-ssa/pr102736.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/testsuite/gcc.dg/tree-ssa/pr102736.c b/gcc/testsuite/gcc.dg/tree-ssa/pr102736.c
index 7e556f01a86..c693a7189dd 100644
--- a/gcc/testsuite/gcc.dg/tree-ssa/pr102736.c
+++ b/gcc/testsuite/gcc.dg/tree-ssa/pr102736.c
@@ -3,8 +3,8 @@
 
 int a, b = -1, c;
 int d = 1;
-static inline char e(char f, int g) { return g ? f : 0; }
-static inline char h(char f) { return f < a ? f : f < a; }
+static inline signed char e(signed char f, int g) { return g ? f : 0; }
+static inline signed char h(signed char f) { return f < a ? f : f < a; }
 static inline unsigned char i(unsigned char f, int g) { return g ? f : f > g; }
 void j() {
 L:
-- 
2.31.1


                 reply	other threads:[~2021-10-15 10:57 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211015105740.267657-1-aldyh@redhat.com \
    --to=aldyh@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).