From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 35A5C3857C69 for ; Fri, 15 Oct 2021 10:57:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 35A5C3857C69 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-41-sobsB3psOXmxlb73kjrlhw-1; Fri, 15 Oct 2021 06:57:50 -0400 X-MC-Unique: sobsB3psOXmxlb73kjrlhw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A0F2D1006AA4; Fri, 15 Oct 2021 10:57:49 +0000 (UTC) Received: from abulafia.quesejoda.com (unknown [10.39.195.60]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 315B410013D7; Fri, 15 Oct 2021 10:57:48 +0000 (UTC) Received: from abulafia.quesejoda.com (localhost [127.0.0.1]) by abulafia.quesejoda.com (8.16.1/8.15.2) with ESMTPS id 19FAvk54267727 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 15 Oct 2021 12:57:46 +0200 Received: (from aldyh@localhost) by abulafia.quesejoda.com (8.16.1/8.16.1/Submit) id 19FAvk2c267726; Fri, 15 Oct 2021 12:57:46 +0200 From: Aldy Hernandez To: GCC patches Subject: [COMMITTED] Make signness explicit in tree-ssa/pr102736.c Date: Fri, 15 Oct 2021 12:57:39 +0200 Message-Id: <20211015105740.267657-1-aldyh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Oct 2021 10:57:53 -0000 This test is failing on ppc64* due to different default signness for chars. Thanks to Richi for quickly pointing out the problem. Tested on x86-64 Linux and ppc64le Linux. gcc/testsuite/ChangeLog: PR testsuite/pr102751 * gcc.dg/tree-ssa/pr102736.c: Make sign explicit. --- gcc/testsuite/gcc.dg/tree-ssa/pr102736.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/testsuite/gcc.dg/tree-ssa/pr102736.c b/gcc/testsuite/gcc.dg/tree-ssa/pr102736.c index 7e556f01a86..c693a7189dd 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/pr102736.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/pr102736.c @@ -3,8 +3,8 @@ int a, b = -1, c; int d = 1; -static inline char e(char f, int g) { return g ? f : 0; } -static inline char h(char f) { return f < a ? f : f < a; } +static inline signed char e(signed char f, int g) { return g ? f : 0; } +static inline signed char h(signed char f) { return f < a ? f : f < a; } static inline unsigned char i(unsigned char f, int g) { return g ? f : f > g; } void j() { L: -- 2.31.1