From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 86E783858404 for ; Mon, 18 Oct 2021 21:17:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 86E783858404 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-254-xDfY4Av0Os-NzM0gyYvQiw-1; Mon, 18 Oct 2021 17:17:06 -0400 X-MC-Unique: xDfY4Av0Os-NzM0gyYvQiw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1892480A5C1; Mon, 18 Oct 2021 21:17:05 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.193.172]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A4E9519C79; Mon, 18 Oct 2021 21:17:04 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 19ILH1Lx2444207 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 18 Oct 2021 23:17:02 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 19ILH0dY2444206; Mon, 18 Oct 2021 23:17:00 +0200 Date: Mon, 18 Oct 2021 23:17:00 +0200 From: Jakub Jelinek To: Kwok Cheung Yeung Cc: Tobias Burnus , gcc-patches , fortran Subject: Re: [PATCH] openmp, fortran: Add support for declare variant in Fortran Message-ID: <20211018211700.GI304296@tucnak> Reply-To: Jakub Jelinek References: <8296c73e-2a16-0232-d1ac-49c5c7330481@codesourcery.com> <20211006153635.GJ304296@tucnak> <20211014124701.GZ304296@tucnak> <0d554b80-c396-6707-a2c5-aec448ec3528@codesourcery.com> MIME-Version: 1.0 In-Reply-To: <0d554b80-c396-6707-a2c5-aec448ec3528@codesourcery.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=unavailable autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2021 21:17:10 -0000 On Mon, Oct 18, 2021 at 10:05:29PM +0100, Kwok Cheung Yeung wrote: > On 14/10/2021 1:47 pm, Jakub Jelinek wrote: > > What I still miss is tests for the (proc_name : variant_name) syntax > > in places where proc_name : is optional, but is supplied and is valid, like > > e.g. in interface, or in subroutine/function and where proc_name specifies > > the name of the containing interface or subroutine/function. > > I see that syntax tested in some places with dg-error on that line and > > in spaces where it isn't optional (e.g. at module scope before contains). > > But if you want, that can be added incrementally. > > Do you mean something like these tests? Yeah, LGTM, thanks. Jakub