From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lug-owl.de (lug-owl.de [IPv6:2a03:4000:10:469::]) by sourceware.org (Postfix) with ESMTP id 554E83858D39 for ; Tue, 19 Oct 2021 20:39:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 554E83858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=lug-owl.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lug-owl.de Received: by lug-owl.de (Postfix, from userid 1001) id BAD2E41F0A; Tue, 19 Oct 2021 22:39:05 +0200 (CEST) Date: Tue, 19 Oct 2021 22:39:05 +0200 From: Jan-Benedict Glaw To: Aldy Hernandez Cc: GCC patches Subject: Re: [PATCH] Cleanup --params for backward threader. Message-ID: <20211019203905.o6wa5wygbwidf4ed@lug-owl.de> References: <20211014142547.251144-1-aldyh@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="2dpb7q2w74badfnv" Content-Disposition: inline In-Reply-To: <20211014142547.251144-1-aldyh@redhat.com> X-Operating-System: Linux chamaeleon 5.8.0-0.bpo.2-amd64 X-gpg-fingerprint: 250D 3BCF 7127 0D8C A444 A961 1DBD 5E75 8399 E1BB X-gpg-key: wwwkeys.de.pgp.net X-Echelon-Enable: howto poison arsenous mail psychological biological nuclear warfare test the bombastical terror of flooding the spy listeners explosion sex drugs and rock'n'roll X-TKUeV: howto poison arsenous mail psychological biological nuclear warfare test the bombastical terror of flooding the spy listeners explosion sex drugs and rock'n'roll X-message-flag: Please send plain text messages only. Do not send HTML emails. Thank you. User-Agent: NeoMutt/20170113 (1.7.2) X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2021 20:39:09 -0000 --2dpb7q2w74badfnv Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Aldy! On Thu, 2021-10-14 16:25:48 +0200, Aldy Hernandez via Gcc-patches wrote: > The new backward threader makes some of the --param knobs used to > control it questionable at best or no longer applicable at worst. >=20 > The fsm-maximum-phi-arguments param is unused and can be removed. >=20 > The max-fsm-thread-length param is block based which is a bit redundant, > since we already restrict paths based on instruction estimates. >=20 > The max-fsm-thread-paths restricts the total number of threadable paths > in a function. We probably don't need this. Besides, the forward > threader has no such restriction. >=20 > OK pending tests? This causes a regression for me. I'm auto-building lots of GCC cross-compilers and use these to cross-build the Linux kernel. Using binutils/gas/gcc configured for --target=3Dsh-linux (actual configuration for GCC is this: .../gcc/configure --target=3Dsh-linux --enable-werror-always \ --enable-languages=3Dall --disable-gcov \ --disable-shared --disable-threads \ --without-headers \ --prefix=3D/var/lib/laminar/run/gcc-sh-linux/13/t= oolchain-install ) Then, building Linux for a good number of default configurations for ARCH=3Dsh and ARCH=3Darm, GCC will just loop: $ make ARCH=3Dsh distclean $ cp arch/sh/configs/r7780mp_defconfig .config $ make V=3D1 ARCH=3Dsh CROSS_COMPILE=3Dsh-linux- oldconfig < /dev/null $ make V=3D1 ARCH=3Dsh CROSS_COMPILE=3Dsh-linux- prepare $ make V=3D1 ARCH=3Dsh CROSS_COMPILE=3Dsh-linux- all [...] sh-linux-gcc -Wp,-MMD,drivers/ata/.libata-core.o.d -nostdinc -isystem /tm= p/testbed/install/lib/gcc/sh-linux/12.0.0/include -I./arch/sh/include -I./a= rch/sh/include/generated -I./include -I./arch/sh/include/uapi -I./arch/sh/= include/generated/uapi -I./include/uapi -I./include/generated/uapi -include= ./include/linux/compiler-version.h -include ./include/linux/kconfig.h -inc= lude ./include/linux/compiler_types.h -D__KERNEL__ -m4 -m4-nofpu -m4a -m4a-= nofpu -ml -mno-fdpic -Wa,-isa=3Dsh4a-up -ffreestanding -I ./arch/sh/include= /cpu-sh4a -I ./arch/sh/include/cpu-sh4 -I ./arch/sh/include/cpu-common -I .= /arch/sh/include/mach-highlander -I ./arch/sh/include/mach-common -fmacro-p= refix-map=3D./=3D -Wall -Wundef -Werror=3Dstrict-prototypes -Wno-trigraphs = -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE -Werror=3Dimplicit-= function-declaration -Werror=3Dimplicit-int -Werror=3Dreturn-type -Wno-form= at-security -std=3Dgnu89 -pipe -m4 -m4-nofpu -m4a -m4a-nofpu -ml -mno-fdpic= -Wa,-isa=3Dsh4a-up -ffreestanding -I ./arch/sh/include/cpu-sh4a -I ./arch/= sh/include/cpu-sh4 -I ./arch/sh/include/cpu-common -I ./arch/sh/include/mac= h-highlander -I ./arch/sh/include/mach-common -fno-delete-null-pointer-chec= ks -Wno-frame-address -Wno-format-truncation -Wno-format-overflow -Wno-addr= ess-of-packed-member -O2 -fno-allow-store-data-races -Wframe-larger-than=3D= 1024 -fstack-protector-strong -Wimplicit-fallthrough=3D5 -Wno-main -Wno-unu= sed-but-set-variable -Wno-unused-const-variable -fomit-frame-pointer -ftriv= ial-auto-var-init=3Dzero -enable-trivial-auto-var-init-zero-knowing-it-will= -be-removed-from-clang -fno-stack-clash-protection -g -Wdeclaration-after-s= tatement -Wvla -Wno-pointer-sign -Wno-stringop-truncation -Wno-zero-length-= bounds -Wno-array-bounds -Wno-stringop-overflow -Wno-restrict -Wno-maybe-un= initialized -fno-strict-overflow -fno-stack-check -fconserve-stack -Werror= =3Ddate-time -Werror=3Dincompatible-pointer-types -Werror=3Ddesignated-init= -Wno-packed-not-aligned -DKBUILD_MODFILE=3D'"drivers/ata/libata"' -DKBU= ILD_BASENAME=3D'"libata_core"' -DKBUILD_MODNAME=3D'"libata"' -D__KBUILD_MOD= NAME=3Dkmod_libata -c -o drivers/ata/libata-core.o drivers/ata/libata-core.c (gdb) bt #0 0x000000000100318e in vec::operator= [] (ix=3D0, this=3D0x50ee6e0) at ../../gcc/gcc/vec.h:1495 #1 back_jt_path_registry::adjust_paths_after_duplication (this=3D0x7ffdf8b= 6e868, curr_path_num=3D0) at ../../gcc/gcc/tree-ssa-threadupdate.c:2315 #2 0x0000000001003c0d in back_jt_path_registry::duplicate_thread_path (thi= s=3D0x7ffdf8b6e868, entry=3D0x7f92651000c0, exit=3D, region= =3D, n_region=3D8,=20 current_path_no=3D0) at ../../gcc/gcc/tree-ssa-threadupdate.c:2546 #3 0x00000000010051e4 in back_jt_path_registry::update_cfg (this=3D0x7ffdf= 8b6e868) at ../../gcc/gcc/tree-ssa-threadupdate.c:2656 #4 0x0000000001003ecc in jt_path_registry::thread_through_all_blocks (this= =3D0x7ffdf8b6e868, peel_loop_headers=3D) at ../../gcc/gcc/tr= ee-ssa-threadupdate.c:2604 #5 0x0000000000ffb5a7 in back_threader_registry::thread_through_all_blocks= (may_peel_loop_headers=3Dtrue, this=3D0x7ffdf8b6e868) at ../../gcc/gcc/tre= e-ssa-threadbackward.c:556 #6 back_threader::thread_through_all_blocks (may_peel_loop_headers=3Dtrue,= this=3D0x7ffdf8b6e860) at ../../gcc/gcc/tree-ssa-threadbackward.c:501 #7 (anonymous namespace)::try_thread_blocks (fun=3Dfun@entry=3D0x7f926eb38= 9c0) at ../../gcc/gcc/tree-ssa-threadbackward.c:946 #8 0x0000000000ffb5eb in (anonymous namespace)::pass_thread_jumps::execute= (this=3D, fun=3D0x7f926eb389c0) at ../../gcc/gcc/tree-ssa-t= hreadbackward.c:954 #9 0x0000000000cfcdf8 in execute_one_pass (pass=3D0x2a980d0) at ../../gcc/= gcc/passes.c:2567 #10 0x0000000000cfd770 in execute_pass_list_1 (pass=3D0x2a980d0) at ../../g= cc/gcc/passes.c:2656 #11 0x0000000000cfd782 in execute_pass_list_1 (pass=3D0x2a95ab0) at ../../g= cc/gcc/passes.c:2657 #12 0x0000000000cfd7a9 in execute_pass_list (fn=3D0x7f926eb389c0, pass=3D) at ../../gcc/gcc/passes.c:2667 #13 0x00000000009719c6 in cgraph_node::expand (this=3D0x7f926eb59550) at ..= /../gcc/gcc/context.h:48 #14 cgraph_node::expand (this=3D0x7f926eb59550) at ../../gcc/gcc/cgraphunit= =2Ec:1781 #15 0x0000000000972eb8 in expand_all_functions () at ../../gcc/gcc/cgraphun= it.c:1992 #16 symbol_table::compile (this=3D0x7f9271f36000) at ../../gcc/gcc/cgraphun= it.c:2356 #17 0x0000000000975948 in symbol_table::compile (this=3D0x7f9271f36000) at = =2E./../gcc/gcc/cgraphunit.c:2269 #18 symbol_table::finalize_compilation_unit (this=3D0x7f9271f36000) at ../.= =2E/gcc/gcc/cgraphunit.c:2537 #19 0x0000000000de87a6 in compile_file () at ../../gcc/gcc/toplev.c:477 #20 0x00000000007ca783 in do_compile (no_backend=3Dfalse) at ../../gcc/gcc/= toplev.c:2197 #21 toplev::main (this=3Dthis@entry=3D0x7ffdf8b6f00e, argc=3D, argc@entry=3D128, argv=3D, argv@entry=3D0x7ffdf8b6f118) a= t ../../gcc/gcc/toplev.c:2346 #22 0x00000000007cc74f in main (argc=3D128, argv=3D0x7ffdf8b6f118) at ../..= /gcc/gcc/main.c:39 Shall I open a PR for it? MfG, JBG --=20 --2dpb7q2w74badfnv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQQlDTvPcScNjKREqWEdvV51g5nhuwUCYW8s5AAKCRAdvV51g5nh u8HwAJwLbdnAanft9wtV4sp/i5B/nAV9dgCfVmuQIMJcMqgg/UP/GZyK343x058= =y9U5 -----END PGP SIGNATURE----- --2dpb7q2w74badfnv--