From: Pierre-Marie de Rodat <derodat@adacore.com>
To: gcc-patches@gcc.gnu.org
Cc: Ghjuvan Lacambre <lacambre@adacore.com>
Subject: [Ada] Fix deleted Compile_Time warnings causing crashes
Date: Mon, 25 Oct 2021 15:08:50 +0000 [thread overview]
Message-ID: <20211025150850.GA346238@adacore.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 341 bytes --]
Count_Compile_Time_Pragma_Warnings also counted deleted pragmas. This
caused discrepancies ultimately leading to a crash when Compile_Time
warnings were suppressed by a Warnings(Off, ...) pragma.
Tested on x86_64-pc-linux-gnu, committed on trunk
gcc/ada/
* erroutc.adb (Count_Compile_Time_Pragma_Warnings): Don't count
deleted warnings.
[-- Attachment #2: patch.diff --]
[-- Type: text/x-diff, Size: 527 bytes --]
diff --git a/gcc/ada/erroutc.adb b/gcc/ada/erroutc.adb
--- a/gcc/ada/erroutc.adb
+++ b/gcc/ada/erroutc.adb
@@ -277,7 +277,9 @@ package body Erroutc is
begin
for J in 1 .. Errors.Last loop
begin
- if Errors.Table (J).Warn and Errors.Table (J).Compile_Time_Pragma
+ if Errors.Table (J).Warn
+ and then Errors.Table (J).Compile_Time_Pragma
+ and then not Errors.Table (J).Deleted
then
Result := Result + 1;
end if;
reply other threads:[~2021-10-25 15:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211025150850.GA346238@adacore.com \
--to=derodat@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=lacambre@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).