Re: [PATCH] rs6000: Fixes for tests including only <x86intrin.h>

[Segher Boessenkool <segher@kernel.crashing.org>]

Hi!

On Mon, Oct 25, 2021 at 03:33:21PM -0500, Paul A. Clarke wrote:
> 	* config/rs6000/x86intrin.h: Move some included headers to new
> 	headers; include new immintrin.h instead.

s/; i/.  I/  (And instead of what?)

> 	* config/rs6000/immintrin.h: New.
> 	* config/rs6000/x86gprintrin.h: New.

(That is a filename worse than our worst mnemonic :-) )

> 	* config/config.gcc (powerpc-*-*): Add new headers to extra_headers.

powerpc*-*-*

> --- a/gcc/testsuite/gcc.target/powerpc/pr78102.c
> +++ b/gcc/testsuite/gcc.target/powerpc/pr78102.c
> @@ -1,6 +1,6 @@
>  /* { dg-do compile } */
> -/* { dg-options "-O2 -mvsx" } */
> -/* { dg-require-effective-target vsx_hw } */
> +/* { dg-options "-O2 -mpower8-vector -DNO_WARN_X86_INTRINSICS" } */
> +/* { dg-require-effective-target p8vector_hw } */

Please use -mcpu=power8 instead?  (And -mdejagnu-cpu=power8 in
testcases).

(The changelog should say you added the -D btw).

If you run you need *_hw.  If you only compile, like here, you want to
use *_ok instead.

Okay for trunk with those things tuned up.  Thanks!


Segher