From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: Richard Purdie via Gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 2/5] gcc: Fix "argument list too long" from install-plugins
Date: Wed, 27 Oct 2021 22:54:04 +0200 [thread overview]
Message-ID: <20211027225404.4ed7a90b@nbbrfq> (raw)
In-Reply-To: <20211027200505.3340725-3-richard.purdie@linuxfoundation.org>
On Wed, 27 Oct 2021 21:05:02 +0100
Richard Purdie via Gcc-patches <gcc-patches@gcc.gnu.org> wrote:
> When building in longer build paths (200+ characters), the
> "echo $(PLUGIN_HEADERS)" from the install-plugins target would cause an
> "argument list too long error" on some systems.
>
> Avoid this by calling make's sort function on the list which removes
> duplicates and stops the overflow from reaching the echo command.
> The original sort is left to handle the the .h and .def files.
you could as well $(subst $(srcdir),,$(wildcard $(addprefix
$(srcdir),*.h *.def))) and subst '' with '\012' wrapped in an outer
sort to completely do away with the echo and shell sort i suppose.
Just an idea.
thanks,
>
> 2021-10-26 Richard Purdie <richard.purdie@linuxfoundation.org>
>
> gcc/ChangeLog:
>
> * Makefile.in: Fix "argument list too long" from install-plugins
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> gcc/Makefile.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/Makefile.in b/gcc/Makefile.in
> index 658093c11c0..89482c6dd4e 100644
> --- a/gcc/Makefile.in
> +++ b/gcc/Makefile.in
> @@ -3685,7 +3685,7 @@ install-plugin: installdirs lang.install-plugin s-header-vars install-gengtype
> # We keep the directory structure for files in config, common/config or
> # c-family and .def files. All other files are flattened to a single directory.
> $(mkinstalldirs) $(DESTDIR)$(plugin_includedir)
> - headers=`echo $(PLUGIN_HEADERS) $$(cd $(srcdir); echo *.h *.def) | tr ' ' '\012' | sort -u`; \
> + headers=`echo $(sort $(PLUGIN_HEADERS)) $$(cd $(srcdir); echo *.h *.def) | tr ' ' '\012' | sort -u`; \
> srcdirstrip=`echo "$(srcdir)" | sed 's/[].[^$$\\*|]/\\\\&/g'`; \
> for file in $$headers; do \
> if [ -f $$file ] ; then \
next prev parent reply other threads:[~2021-10-27 20:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 20:05 [PATCH 0/5] OpenEmbedded/Yocto Project gcc patches Richard Purdie
2021-10-27 20:05 ` [PATCH 1/5] Makefile.in: Ensure build CPP/CPPFLAGS is used for build targets Richard Purdie
2021-10-28 7:04 ` Richard Biener
2021-10-28 14:43 ` Jeff Law
2021-10-27 20:05 ` [PATCH 2/5] gcc: Fix "argument list too long" from install-plugins Richard Purdie
2021-10-27 20:54 ` Bernhard Reutner-Fischer [this message]
2021-12-03 3:01 ` Jeff Law
2021-10-27 20:05 ` [PATCH 3/5] gcc: Add --nostdlib++ option Richard Purdie
2021-10-27 20:56 ` Bernhard Reutner-Fischer
2021-10-28 16:41 ` Richard Purdie
2021-12-03 3:05 ` Jeff Law
2021-10-28 14:51 ` Jeff Law
2021-10-28 16:39 ` Richard Purdie
2021-12-03 3:04 ` Jeff Law
2021-12-05 11:43 ` Richard Purdie
2021-12-06 6:10 ` Fāng-ruì Sòng
2021-10-27 20:05 ` [PATCH 4/5] gcc/nios2: Define the musl linker Richard Purdie
2021-10-28 14:46 ` Jeff Law
2021-10-27 20:05 ` [PATCH 5/5] gcc: Pass sysroot options to cpp for preprocessed source Richard Purdie
2021-12-14 23:47 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211027225404.4ed7a90b@nbbrfq \
--to=rep.dot.nop@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).