From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by sourceware.org (Postfix) with ESMTPS id 0B620385842D; Fri, 29 Oct 2021 18:19:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0B620385842D Received: by mail-wr1-x433.google.com with SMTP id d3so17667435wrh.8; Fri, 29 Oct 2021 11:19:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bSdARwVPusCr292eHdI2ym+jfjfBKjF6EZf7s2F64ug=; b=idMBU6oVOEtDQd+oRuZx1Krg0bz8tgIBBrkDJh+athJcy1hIk4xhWzyQg2HWAEIw5K Y7RHCs9IDQGNfunbGbUnX7YDiXfxxJLvNAVV+IIj1QoGZqx/gqejBOtWdET7Pzd9krM/ 1Pbim1a+6EWB4nx3BHQsOAThMQaCGFs8TFKa6q/4gUjtoao/xnDz2lPn6Q16TveKMd20 qdQnGqK1MsLgSlUeIzUZvugL51At/Kk0qNmdGbslqhCDoiYTXMXwA9NMyeaiVF5kfjE8 9IJ79s9OsheuSxcMMAwPn+L0jVTFKRKLQUyUhLMNyMBHcQ2tA+dr8RtkeSLEvG+5rabf qJkA== X-Gm-Message-State: AOAM532Ya2TNVzUUDznwFa/wa/rd3Kz+C+gGRsmvTXnCGJ1GWWmtAmJW 4r93CqkEM388DJ03KwgiVZ4= X-Google-Smtp-Source: ABdhPJwkztkuK49//a+RwenRT6/nGLjjK8OnoNk4ZJlsxWoSHanjA1coQZWy5uy1EV+mwpgUp3HCTw== X-Received: by 2002:adf:e306:: with SMTP id b6mr16109927wrj.244.1635531559123; Fri, 29 Oct 2021 11:19:19 -0700 (PDT) Received: from nbbrfq (dynamic-2bq7di4u2lfl4qjka9-pd01.res.v6.highway.a1.net. [2001:871:227:33a8:f6a3:c58c:7641:e771]) by smtp.gmail.com with ESMTPSA id w14sm5381590wmi.37.2021.10.29.11.19.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Oct 2021 11:19:18 -0700 (PDT) Date: Fri, 29 Oct 2021 20:19:15 +0200 From: Bernhard Reutner-Fischer To: Harald Anlauf via Fortran Cc: rep.dot.nop@gmail.com, Harald Anlauf , gcc-patches Subject: Re: [PATCH] PR fortran/99853 - ICE: Cannot convert 'LOGICAL(4)' to 'INTEGER(8)' (etc.) Message-ID: <20211029201915.68de7ac5@nbbrfq> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Oct 2021 18:19:22 -0000 On Thu, 28 Oct 2021 23:03:05 +0200 Harald Anlauf via Fortran wrote: > Dear Fortranners, > > the original fix by Steve was lingering in the PR. > > We did ICE in situations where in a SELECT CASE a kind conversion > was deemed necessary, but it did involve different types. > The check gfc_convert_type_warn () was invoked with arguments > requesting to generate an internal error. A regular gfc_error > is good enough here. > > Regtested on x86_64-pc-linux-gnu. OK? Sounds plausible but i cannot approve it. PS: git commit --author 'Steve Kargl ' would give Steve due credit i suppose. Or throw in --amend if you applied it already to your local tree (e.g rebase -i and reword the message, then git commit --amend --author ...). HTH. > > Thanks, also to Steve, thanks, > > Harald > > > Fortran: generate regular error on invalid conversions of CASE expressions > > gcc/fortran/ChangeLog: > > PR fortran/99853 > * resolve.c (resolve_select): Generate regular gfc_error on > invalid conversions instead of an gfc_internal_error. > > gcc/testsuite/ChangeLog: > > PR fortran/99853 > * gfortran.dg/pr99853.f90: New test. >