From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by sourceware.org (Postfix) with ESMTPS id E5FE43858D35 for ; Fri, 5 Nov 2021 02:20:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E5FE43858D35 X-IronPort-AV: E=McAfee;i="6200,9189,10158"; a="292666972" X-IronPort-AV: E=Sophos;i="5.87,210,1631602800"; d="scan'208";a="292666972" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2021 19:20:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,210,1631602800"; d="scan'208";a="639592051" Received: from scymds01.sc.intel.com ([10.148.94.138]) by fmsmga001.fm.intel.com with ESMTP; 04 Nov 2021 19:20:26 -0700 Received: from shliclel051.sh.intel.com (shliclel051.sh.intel.com [10.239.236.51]) by scymds01.sc.intel.com with ESMTP id 1A52KOEa006996; Thu, 4 Nov 2021 19:20:25 -0700 From: liuhongt To: gcc-patches@gcc.gnu.org Cc: joseph@codesourcery.com, richard.guenther@gmail.com Subject: [PATCH] Add !flag_signaling_nans to simplifcation: (trunc)copysign((extend)a, (extend)b) to copysign (a, b). Date: Fri, 5 Nov 2021 10:20:24 +0800 Message-Id: <20211105022024.27921-1-hongtao.liu@intel.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: References: X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_NONE, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2021 02:20:30 -0000 > Note that this is not safe with -fsignaling-nans, so needs to be disabled > for that option (if there isn't already logic somewhere with that effect), > because the extend will convert a signaling NaN to quiet (raising > "invalid"), but copysign won't, so this transformation could result in a > signaling NaN being wrongly returned when the original code would never > have returned a signaling NaN. > > -- > Joseph S. Myers > joseph@codesourcery.com Bootstrapped and regtested on x86_64-linux-gnu{-m32,}. Ok for trunk? gcc/ChangeLog * match.pd (Simplifcation (trunc)copysign((extend)a, (extend)b) to .COPYSIGN (a, b)): Add !flag_signaling_nans. --- gcc/match.pd | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/match.pd b/gcc/match.pd index fb1065dc0e6..d6a8dd0dd20 100644 --- a/gcc/match.pd +++ b/gcc/match.pd @@ -6176,6 +6176,7 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) (simplify (convert (copysigns (convert@2 @0) (convert @1))) (if (optimize + && !flag_signaling_nans && types_match (type, TREE_TYPE (@0)) && types_match (type, TREE_TYPE (@1)) && TYPE_PRECISION (type) < TYPE_PRECISION (TREE_TYPE (@2)) -- 2.18.1