From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <segher@kernel.crashing.org>
Received: from gate.crashing.org (gate.crashing.org [63.228.1.57])
 by sourceware.org (Postfix) with ESMTP id C1C19385840A
 for <gcc-patches@gcc.gnu.org>; Fri,  5 Nov 2021 20:37:46 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C1C19385840A
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none)
 header.from=kernel.crashing.org
Authentication-Results: sourceware.org;
 spf=pass smtp.mailfrom=kernel.crashing.org
Received: from gate.crashing.org (localhost.localdomain [127.0.0.1])
 by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 1A5KakF5026741;
 Fri, 5 Nov 2021 15:36:46 -0500
Received: (from segher@localhost)
 by gate.crashing.org (8.14.1/8.14.1/Submit) id 1A5Kaj63026739;
 Fri, 5 Nov 2021 15:36:45 -0500
X-Authentication-Warning: gate.crashing.org: segher set sender to
 segher@kernel.crashing.org using -f
Date: Fri, 5 Nov 2021 15:36:45 -0500
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Bill Schmidt <wschmidt@linux.ibm.com>
Cc: gcc-patches@gcc.gnu.org, dje.gcc@gmail.com
Subject: Re: [PATCH 13/18] rs6000: Miscellaneous uses of rs6000_builtins_decl_x
Message-ID: <20211105203645.GQ614@gate.crashing.org>
References: <cover.1630511334.git.wschmidt@linux.ibm.com>
 <b0d969a8394a4431b694cb1179dee260b3a0afa6.1630511335.git.wschmidt@linux.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b0d969a8394a4431b694cb1179dee260b3a0afa6.1630511335.git.wschmidt@linux.ibm.com>
User-Agent: Mutt/1.4.2.3i
X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Nov 2021 20:37:47 -0000

Hi!

On Wed, Sep 01, 2021 at 11:13:49AM -0500, Bill Schmidt wrote:
> 	* config/rs6000/rs6000.c (rs6000_builtin_reciprocal): Use
> 	rs6000_builtin_decls_x when appropriate.
> 	(add_condition_to_bb): Likewise.
> 	(rs6000_atomic_assign_expand_fenv): Likewise.

> +  tree predicate_decl
> +    = (new_builtins_are_live
> +       ? rs6000_builtin_decls_x[(int) RS6000_BIF_CPU_SUPPORTS]
> +       : rs6000_builtin_decls [(int) RS6000_BUILTIN_CPU_SUPPORTS]);

Please don't randomly parenthesise stuff.  If something in emacs
complains about it, fix *that*?  Or complain back, etc. :-)

> -  tree mffs = rs6000_builtin_decls[RS6000_BUILTIN_MFFS];
> -  tree mtfsf = rs6000_builtin_decls[RS6000_BUILTIN_MTFSF];
> +  tree mffs
> +    = (new_builtins_are_live
> +       ? rs6000_builtin_decls_x[RS6000_BIF_MFFS]
> +       : rs6000_builtin_decls[RS6000_BUILTIN_MFFS]);
> +  tree mtfsf
> +    = (new_builtins_are_live
> +       ? rs6000_builtin_decls_x[RS6000_BIF_MTFSF]
> +       : rs6000_builtin_decls[RS6000_BUILTIN_MTFSF]);
>    tree call_mffs = build_call_expr (mffs, 0);

Same here.

Okay for trunk with that fixed.  Thanks!


Segher