From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id 8F6B03858030 for ; Fri, 5 Nov 2021 22:09:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8F6B03858030 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 1A5M8rsE003629; Fri, 5 Nov 2021 17:08:53 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 1A5M8rMd003628; Fri, 5 Nov 2021 17:08:53 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Fri, 5 Nov 2021 17:08:53 -0500 From: Segher Boessenkool To: Bill Schmidt Cc: gcc-patches@gcc.gnu.org, dje.gcc@gmail.com Subject: Re: [PATCH 15/18] rs6000: Update altivec.h for automated interfaces Message-ID: <20211105220853.GS614@gate.crashing.org> References: <26b0448dc84249d7dfd761fbb35a29b0d828cfad.1630511335.git.wschmidt@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <26b0448dc84249d7dfd761fbb35a29b0d828cfad.1630511335.git.wschmidt@linux.ibm.com> User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2021 22:09:55 -0000 On Wed, Sep 01, 2021 at 11:13:51AM -0500, Bill Schmidt wrote: > gcc/ > * config/rs6000/altivec.h: Delete a number of #defines that are > now superfluous. Alphabetize. Include rs6000-vecdefines.h. > Include some synonyms. * config/rs6000/altivec.h: Delete a number of #defines that are now superfluous. Alphabetize. Include rs6000-vecdefines.h. Include some synonyms. This looks good, but I cannot easily check any of it. And I doubt the testsuite tests if all of this is defined correctly. How did you test this, maybe you can add a testcase to check this? Okay for trunk. Thanks! Segher