From: Pierre-Marie de Rodat <derodat@adacore.com>
To: gcc-patches@gcc.gnu.org
Cc: Piotr Trojanek <trojanek@adacore.com>
Subject: [Ada] Cleanup copying of parameter lists
Date: Tue, 9 Nov 2021 09:46:06 +0000 [thread overview]
Message-ID: <20211109094606.GA830515@adacore.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 244 bytes --]
Cleanup related to expansion of predefined equality for GNATprove;
semantics is unaffected.
Tested on x86_64-pc-linux-gnu, committed on trunk
gcc/ada/
* sem_util.adb (Copy_Parameter_List): Refactor to remove
repeated calls to First_Formal.
[-- Attachment #2: patch.diff --]
[-- Type: text/x-diff, Size: 924 bytes --]
diff --git a/gcc/ada/sem_util.adb b/gcc/ada/sem_util.adb
--- a/gcc/ada/sem_util.adb
+++ b/gcc/ada/sem_util.adb
@@ -6797,14 +6797,11 @@ package body Sem_Util is
function Copy_Parameter_List (Subp_Id : Entity_Id) return List_Id is
Loc : constant Source_Ptr := Sloc (Subp_Id);
Plist : List_Id;
- Formal : Entity_Id;
+ Formal : Entity_Id := First_Formal (Subp_Id);
begin
- if No (First_Formal (Subp_Id)) then
- return No_List;
- else
- Plist := New_List;
- Formal := First_Formal (Subp_Id);
+ if Present (Formal) then
+ Plist := New_List;
while Present (Formal) loop
Append_To (Plist,
Make_Parameter_Specification (Loc,
@@ -6819,6 +6816,8 @@ package body Sem_Util is
Next_Formal (Formal);
end loop;
+ else
+ Plist := No_List;
end if;
return Plist;
reply other threads:[~2021-11-09 9:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211109094606.GA830515@adacore.com \
--to=derodat@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=trojanek@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).