From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by sourceware.org (Postfix) with ESMTPS id 359EA3858404 for ; Tue, 9 Nov 2021 19:47:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 359EA3858404 Received: by mail-wm1-x32b.google.com with SMTP id a20-20020a1c7f14000000b003231d13ee3cso2791635wmd.3 for ; Tue, 09 Nov 2021 11:47:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FDi0HvbJdPAkJOLBDf8AmTr4NMo+Hfhy6chSmnXJQGI=; b=2obPKRzFdrwDrD8wniHD4V4O5ZHnXVQ4ALZwbR145zfoutUwxix8wZBFmkgdGNFd1z fEr3ujr0JQFbtBu2S3kInGQAyLzfgz2AnesD0OYTcW+KlM2/Phn+I0SlVnwdyPcztfp8 cMOlJ+wiBSDdha9d6rb833bFbxk5OVJejTK+ZQFmYc+TTfEhjZR1tB2i+GlvS38tu2dw DrJr2USvrDLt/6MtjYW2h+81YM2B5Ea/asydYF9yU3coqdPWh0swTM/2euj8AquEnAoz uNS+rDcT/SN+71YPiC2UGrJECnPXmLX9vhVoQ27uaDivqa1B5YtSXtPKHj/sIyhSI0dz az3g== X-Gm-Message-State: AOAM530eDpGRZ6t3q9EQEN10YWyB/3Wn0/7P7JUyy3s1kErIyWxjqach aPG/sPV+ZqLgYnFb6C0DRTE= X-Google-Smtp-Source: ABdhPJzqeUzG8uJgxeuq6vvX0+i43Ls30t0wIJj+NTEnvmIz9UizC0EP7HsJX0jimkiWsk63d+My4w== X-Received: by 2002:a05:600c:4e91:: with SMTP id f17mr10287543wmq.195.1636487226205; Tue, 09 Nov 2021 11:47:06 -0800 (PST) Received: from nbbrfq (91-119-98-250.dsl.dynamic.surfer.at. [91.119.98.250]) by smtp.gmail.com with ESMTPSA id t127sm3677568wma.9.2021.11.09.11.47.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Nov 2021 11:47:05 -0800 (PST) Date: Tue, 9 Nov 2021 20:47:02 +0100 From: Bernhard Reutner-Fischer To: Marek Polacek Cc: rep.dot.nop@gmail.com, Jason Merrill , Marek Polacek via Gcc-patches , Jakub Jelinek Subject: Re: [PATCH v7] attribs: Implement -Wno-attributes=vendor::attr [PR101940] Message-ID: <20211109204702.20ad0fb2@nbbrfq> In-Reply-To: References: <89690210-3ac3-9486-1fa0-742fc67d3748@redhat.com> <84D9B2CE-EA9B-46FB-9BF5-809D29B7018E@gmail.com> <516f3ddd-8634-9d73-ddd4-ae470f4284cf@redhat.com> <20211109080910.2eae4f69@nbbrfq> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Nov 2021 19:47:11 -0000 On Tue, 9 Nov 2021 14:17:14 -0500 Marek Polacek wrote: > + if (!valid_p (vendor_start, vendor_len) > + || !valid_p (attr_start, attr_len)) > + { > + error ("wrong argument to ignored attributes"); > + continue; > + } > + canonicalize_attr_name (vendor_start, vendor_len); > + /* We perform all this hijinks so that we don't have to copy OPT. */ > + tree vendor_id = get_identifier_with_length (vendor_start, vendor_len); [[____::attry]] void f17y(); /* { dg-warning "ignored" } */ so i'd maybe put the || !canonicalize_attr_name (vendor_start, vendor_len) in the condition above? thanks,