From: Segher Boessenkool <segher@kernel.crashing.org>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] rs6000, libgcc: Fix up -Wmissing-prototypes warning on rs6000/linux-unwind.h
Date: Wed, 10 Nov 2021 02:54:05 -0600 [thread overview]
Message-ID: <20211110085405.GA614@gate.crashing.org> (raw)
In-Reply-To: <20211110083912.GD2710@tucnak>
On Wed, Nov 10, 2021 at 09:39:12AM +0100, Jakub Jelinek wrote:
> Hi!
>
> Jonathan reported and I've verified a
> In file included from ../../../libgcc/unwind-dw2.c:412:
> ./md-unwind-support.h:398:6: warning: no previous prototype for ‘ppc_backchain_fallback’ [-Wmissing-prototypes]
> 398 | void ppc_backchain_fallback (struct _Unwind_Context *context, void *a)
> | ^~~~~~~~~~~~~~~~~~~~~~
> warning on powerpc*-linux* libgcc build.
>
> All the other MD_* macro functions are static, so I think the following
> is the right thing rather than adding a previous prototype for
> ppc_backchain_fallback.
>
> Bootstrapped/regtested on powerpc64le-linux and powerpc64-linux (the latter
> with -m32/-m64 testing), ok for trunk?
Yes please. Thanks!
Segher
> 2021-11-09 Jakub Jelinek <jakub@redhat.com>
>
> * config/rs6000/linux-unwind.h (ppc_back_fallback): Make it static,
> formatting fix.
prev parent reply other threads:[~2021-11-10 8:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 8:39 Jakub Jelinek
2021-11-10 8:54 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211110085405.GA614@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).