* [PATCH] rs6000, libgcc: Fix up -Wmissing-prototypes warning on rs6000/linux-unwind.h
@ 2021-11-10 8:39 Jakub Jelinek
2021-11-10 8:54 ` Segher Boessenkool
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2021-11-10 8:39 UTC (permalink / raw)
To: Segher Boessenkool; +Cc: gcc-patches
Hi!
Jonathan reported and I've verified a
In file included from ../../../libgcc/unwind-dw2.c:412:
./md-unwind-support.h:398:6: warning: no previous prototype for ‘ppc_backchain_fallback’ [-Wmissing-prototypes]
398 | void ppc_backchain_fallback (struct _Unwind_Context *context, void *a)
| ^~~~~~~~~~~~~~~~~~~~~~
warning on powerpc*-linux* libgcc build.
All the other MD_* macro functions are static, so I think the following
is the right thing rather than adding a previous prototype for
ppc_backchain_fallback.
Bootstrapped/regtested on powerpc64le-linux and powerpc64-linux (the latter
with -m32/-m64 testing), ok for trunk?
2021-11-09 Jakub Jelinek <jakub@redhat.com>
* config/rs6000/linux-unwind.h (ppc_back_fallback): Make it static,
formatting fix.
--- libgcc/config/rs6000/linux-unwind.h.jj 2021-10-15 11:59:16.227682621 +0200
+++ libgcc/config/rs6000/linux-unwind.h 2021-11-09 11:42:06.840353422 +0100
@@ -395,7 +395,8 @@ struct frame_layout
};
-void ppc_backchain_fallback (struct _Unwind_Context *context, void *a)
+static void
+ppc_backchain_fallback (struct _Unwind_Context *context, void *a)
{
struct frame_layout *current;
struct trace_arg *arg = a;
Jakub
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] rs6000, libgcc: Fix up -Wmissing-prototypes warning on rs6000/linux-unwind.h
2021-11-10 8:39 [PATCH] rs6000, libgcc: Fix up -Wmissing-prototypes warning on rs6000/linux-unwind.h Jakub Jelinek
@ 2021-11-10 8:54 ` Segher Boessenkool
0 siblings, 0 replies; 2+ messages in thread
From: Segher Boessenkool @ 2021-11-10 8:54 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: gcc-patches
On Wed, Nov 10, 2021 at 09:39:12AM +0100, Jakub Jelinek wrote:
> Hi!
>
> Jonathan reported and I've verified a
> In file included from ../../../libgcc/unwind-dw2.c:412:
> ./md-unwind-support.h:398:6: warning: no previous prototype for ‘ppc_backchain_fallback’ [-Wmissing-prototypes]
> 398 | void ppc_backchain_fallback (struct _Unwind_Context *context, void *a)
> | ^~~~~~~~~~~~~~~~~~~~~~
> warning on powerpc*-linux* libgcc build.
>
> All the other MD_* macro functions are static, so I think the following
> is the right thing rather than adding a previous prototype for
> ppc_backchain_fallback.
>
> Bootstrapped/regtested on powerpc64le-linux and powerpc64-linux (the latter
> with -m32/-m64 testing), ok for trunk?
Yes please. Thanks!
Segher
> 2021-11-09 Jakub Jelinek <jakub@redhat.com>
>
> * config/rs6000/linux-unwind.h (ppc_back_fallback): Make it static,
> formatting fix.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-10 8:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-10 8:39 [PATCH] rs6000, libgcc: Fix up -Wmissing-prototypes warning on rs6000/linux-unwind.h Jakub Jelinek
2021-11-10 8:54 ` Segher Boessenkool
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).