* [PATCH] powerpc: Remove LINK_OS_EXTRA_SPEC{32, 64} from --with-advance-toolchain
@ 2021-11-09 13:39 Lucas A. M. Magalhaes
2021-11-09 14:19 ` Segher Boessenkool
0 siblings, 1 reply; 6+ messages in thread
From: Lucas A. M. Magalhaes @ 2021-11-09 13:39 UTC (permalink / raw)
To: gcc-patches; +Cc: dje.gcc, segher, meissner
Ping.
-- >8 --
Historically this was added to fill gaps from ld.so.cache on early AT
releases. This now are just causing errors and rework. Since AT5.0 the
AT's ld.so is using a correctly configured ld.so.cache and sets the
DT_INTERP to AT's ld.so. This two factors are sufficient for an AT
builded program to get the correct libraries.
GCC congured with --with-advance-toolchain has issues building GlibC
releases because it adds DT_RUNPATH to ld.so and that's unsupported.
2021-03-11 Lucas A. M. Magalhães <lamm@linux.ibm.com>
gcc/
* config.gcc (powerpc*-*-*): Remove -rpath from
--with-advance-toochain
---
gcc/config.gcc | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/gcc/config.gcc b/gcc/config.gcc
index fb1f06f3da8..9eba3ece0a9 100644
--- a/gcc/config.gcc
+++ b/gcc/config.gcc
@@ -5088,16 +5088,6 @@ case "${target}" in
(at="/opt/$with_advance_toolchain"
echo "/* Use Advance Toolchain $at */"
echo
- echo "#undef LINK_OS_EXTRA_SPEC32"
- echo "#define LINK_OS_EXTRA_SPEC32" \
- "\"%(link_os_new_dtags)" \
- "-rpath $prefix/lib -rpath $at/lib\""
- echo
- echo "#undef LINK_OS_EXTRA_SPEC64"
- echo "#define LINK_OS_EXTRA_SPEC64" \
- "\"%(link_os_new_dtags)" \
- "-rpath $prefix/lib64 -rpath $at/lib64\""
- echo
echo "#undef LINK_OS_NEW_DTAGS_SPEC"
echo "#define LINK_OS_NEW_DTAGS_SPEC" \
"\"--enable-new-dtags\""
--
2.31.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] powerpc: Remove LINK_OS_EXTRA_SPEC{32, 64} from --with-advance-toolchain
2021-11-09 13:39 [PATCH] powerpc: Remove LINK_OS_EXTRA_SPEC{32, 64} from --with-advance-toolchain Lucas A. M. Magalhaes
@ 2021-11-09 14:19 ` Segher Boessenkool
2021-11-09 19:03 ` Lucas A. M. Magalhaes
2021-11-10 14:21 ` [PATCH v2] " Lucas A. M. Magalhaes
0 siblings, 2 replies; 6+ messages in thread
From: Segher Boessenkool @ 2021-11-09 14:19 UTC (permalink / raw)
To: Lucas A. M. Magalhaes; +Cc: gcc-patches, dje.gcc, meissner
Hi!
On Tue, Nov 09, 2021 at 10:39:46AM -0300, Lucas A. M. Magalhaes wrote:
> Ping.
I did not get the original, and neither did the archives?
> Historically this was added to fill gaps from ld.so.cache on early AT
> releases. This now are just causing errors and rework. Since AT5.0 the
> AT's ld.so is using a correctly configured ld.so.cache and sets the
> DT_INTERP to AT's ld.so. This two factors are sufficient for an AT
> builded program to get the correct libraries.
>
> GCC congured with --with-advance-toolchain has issues building GlibC
> releases because it adds DT_RUNPATH to ld.so and that's unsupported.
>
> 2021-03-11 Lucas A. M. Magalhães <lamm@linux.ibm.com>
2021-11-03
> * config.gcc (powerpc*-*-*): Remove -rpath from
> --with-advance-toochain
The start of the line aligns with the star. Changelog lines end in a
full stop. It's "toolchain".
The patch is okay for trunk. Thanks! Do you need backports as well?
Those are fine as well :-)
Segher
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] powerpc: Remove LINK_OS_EXTRA_SPEC{32, 64} from --with-advance-toolchain
2021-11-09 14:19 ` Segher Boessenkool
@ 2021-11-09 19:03 ` Lucas A. M. Magalhaes
2021-11-10 14:39 ` Segher Boessenkool
2021-11-10 14:21 ` [PATCH v2] " Lucas A. M. Magalhaes
1 sibling, 1 reply; 6+ messages in thread
From: Lucas A. M. Magalhaes @ 2021-11-09 19:03 UTC (permalink / raw)
To: Segher Boessenkool; +Cc: gcc-patches, dje.gcc, meissner
Quoting Segher Boessenkool (2021-11-09 11:19:58)
> Hi!
>
> On Tue, Nov 09, 2021 at 10:39:46AM -0300, Lucas A. M. Magalhaes wrote:
> > Ping.
>
> I did not get the original, and neither did the archives?
>
Strange, it's on the archives.
https://gcc.gnu.org/pipermail/gcc-patches/2021-October/582643.html
Looking at my local mails, I did't receive it as well.
> > Historically this was added to fill gaps from ld.so.cache on early AT
> > releases. This now are just causing errors and rework. Since AT5.0 the
> > AT's ld.so is using a correctly configured ld.so.cache and sets the
> > DT_INTERP to AT's ld.so. This two factors are sufficient for an AT
> > builded program to get the correct libraries.
> >
> > GCC congured with --with-advance-toolchain has issues building GlibC
> > releases because it adds DT_RUNPATH to ld.so and that's unsupported.
> >
> > 2021-03-11 Lucas A. M. Magalhães <lamm@linux.ibm.com>
>
> 2021-11-03
>
> > * config.gcc (powerpc*-*-*): Remove -rpath from
> > --with-advance-toochain
>
> The start of the line aligns with the star. Changelog lines end in a
> full stop. It's "toolchain".
>
> The patch is okay for trunk. Thanks! Do you need backports as well?
> Those are fine as well :-)
I don't think we need a backport.
Segher can you push this with the changes or should I send a V2?
---
Lucas A. M. Magalhães
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] powerpc: Remove LINK_OS_EXTRA_SPEC{32, 64} from --with-advance-toolchain
2021-11-09 14:19 ` Segher Boessenkool
2021-11-09 19:03 ` Lucas A. M. Magalhaes
@ 2021-11-10 14:21 ` Lucas A. M. Magalhaes
2021-11-10 14:37 ` Segher Boessenkool
1 sibling, 1 reply; 6+ messages in thread
From: Lucas A. M. Magalhaes @ 2021-11-10 14:21 UTC (permalink / raw)
To: gcc-patches; +Cc: dje.gcc, segher, meissner
Historically this was added to fill gaps from ld.so.cache on early AT
releases. This now are just causing errors and rework. Since AT5.0 the
AT's ld.so is using a correctly configured ld.so.cache and sets the
DT_INTERP to AT's ld.so. This two factors are sufficient for an AT
builded program to get the correct libraries.
GCC congured with --with-advance-toolchain has issues building GlibC
releases because it adds DT_RUNPATH to ld.so and that's unsupported.
2021-11-10 Lucas A. M. Magalhães <lamm@linux.ibm.com>
gcc/
* config.gcc (powerpc*-*-*): Remove -rpath from
--with-advance-toochain
---
gcc/config.gcc | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/gcc/config.gcc b/gcc/config.gcc
index fb1f06f3da8..9eba3ece0a9 100644
--- a/gcc/config.gcc
+++ b/gcc/config.gcc
@@ -5088,16 +5088,6 @@ case "${target}" in
(at="/opt/$with_advance_toolchain"
echo "/* Use Advance Toolchain $at */"
echo
- echo "#undef LINK_OS_EXTRA_SPEC32"
- echo "#define LINK_OS_EXTRA_SPEC32" \
- "\"%(link_os_new_dtags)" \
- "-rpath $prefix/lib -rpath $at/lib\""
- echo
- echo "#undef LINK_OS_EXTRA_SPEC64"
- echo "#define LINK_OS_EXTRA_SPEC64" \
- "\"%(link_os_new_dtags)" \
- "-rpath $prefix/lib64 -rpath $at/lib64\""
- echo
echo "#undef LINK_OS_NEW_DTAGS_SPEC"
echo "#define LINK_OS_NEW_DTAGS_SPEC" \
"\"--enable-new-dtags\""
--
2.31.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] powerpc: Remove LINK_OS_EXTRA_SPEC{32, 64} from --with-advance-toolchain
2021-11-10 14:21 ` [PATCH v2] " Lucas A. M. Magalhaes
@ 2021-11-10 14:37 ` Segher Boessenkool
0 siblings, 0 replies; 6+ messages in thread
From: Segher Boessenkool @ 2021-11-10 14:37 UTC (permalink / raw)
To: Lucas A. M. Magalhaes; +Cc: gcc-patches, dje.gcc, meissner
On Wed, Nov 10, 2021 at 11:21:26AM -0300, Lucas A. M. Magalhaes wrote:
> Historically this was added to fill gaps from ld.so.cache on early AT
> releases. This now are just causing errors and rework. Since AT5.0 the
> AT's ld.so is using a correctly configured ld.so.cache and sets the
> DT_INTERP to AT's ld.so. This two factors are sufficient for an AT
> builded program to get the correct libraries.
>
> GCC congured with --with-advance-toolchain has issues building GlibC
> releases because it adds DT_RUNPATH to ld.so and that's unsupported.
>
> 2021-11-10 Lucas A. M. Magalhães <lamm@linux.ibm.com>
>
> gcc/
> * config.gcc (powerpc*-*-*): Remove -rpath from
> --with-advance-toochain
I fixed the title and this last line, and pushed it to trunk. Thanks!
Segher
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] powerpc: Remove LINK_OS_EXTRA_SPEC{32, 64} from --with-advance-toolchain
2021-11-09 19:03 ` Lucas A. M. Magalhaes
@ 2021-11-10 14:39 ` Segher Boessenkool
0 siblings, 0 replies; 6+ messages in thread
From: Segher Boessenkool @ 2021-11-10 14:39 UTC (permalink / raw)
To: Lucas A. M. Magalhaes; +Cc: gcc-patches, dje.gcc, meissner
On Tue, Nov 09, 2021 at 04:03:55PM -0300, Lucas A. M. Magalhaes wrote:
> Quoting Segher Boessenkool (2021-11-09 11:19:58)
> > On Tue, Nov 09, 2021 at 10:39:46AM -0300, Lucas A. M. Magalhaes wrote:
> > > Ping.
> >
> > I did not get the original, and neither did the archives?
> >
> Strange, it's on the archives.
> https://gcc.gnu.org/pipermail/gcc-patches/2021-October/582643.html
> Looking at my local mails, I did't receive it as well.
Ah. Because your changelog suggested this patch is from November, I
didn't look at earlier archives :-)
Segher
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-11-10 14:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-09 13:39 [PATCH] powerpc: Remove LINK_OS_EXTRA_SPEC{32, 64} from --with-advance-toolchain Lucas A. M. Magalhaes
2021-11-09 14:19 ` Segher Boessenkool
2021-11-09 19:03 ` Lucas A. M. Magalhaes
2021-11-10 14:39 ` Segher Boessenkool
2021-11-10 14:21 ` [PATCH v2] " Lucas A. M. Magalhaes
2021-11-10 14:37 ` Segher Boessenkool
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).