From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 59919385803D for ; Fri, 12 Nov 2021 12:02:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 59919385803D Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-327-9uZDeuqJOiKP9o2Y4wNFsA-1; Fri, 12 Nov 2021 07:02:39 -0500 X-MC-Unique: 9uZDeuqJOiKP9o2Y4wNFsA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 70F218030AF; Fri, 12 Nov 2021 12:02:38 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.54]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 028BF604CC; Fri, 12 Nov 2021 12:02:37 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 1ACC2Z4i158824 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 12 Nov 2021 13:02:35 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 1ACC2YjN158823; Fri, 12 Nov 2021 13:02:34 +0100 Date: Fri, 12 Nov 2021 13:02:34 +0100 From: Jakub Jelinek To: Tobias Burnus Cc: gcc-patches , fortran Subject: Re: [Patch] Fortran/openmp: Fix '!$omp end' Message-ID: <20211112120234.GB2710@tucnak> Reply-To: Jakub Jelinek References: <20211111180114.GU2710@tucnak> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=unavailable autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Nov 2021 12:02:44 -0000 On Fri, Nov 12, 2021 at 12:01:27PM +0100, Tobias Burnus wrote: > With the attached patch, the following combined/composite > directives accept 'nowait' at 'end': I've filed https://github.com/OpenMP/spec/issues/3184 because I think OpenMP 5.2 got it wrong (and 5.1 got it wrong for the end directives in many other cases too). I believe the general rule should be: 1) non-combined/composite constructs allow nowait when they mention the clause (critical, for/do, scope, sections, single, workshare) 2) for simd, do simd allow it 3) anything combined with target allows it So: > > "end critical" > "end do simd" > "end do" > "end scope" > "end sections" > "end single" > "end target parallel" (newly permits nowait) > "end target simd" (newly permits nowait) > "end target teams distribute simd" (newly permits nowait) > "end target teams distribute" (newly permits nowait) > "end target teams loop" (newly permits nowait) > "end target teams" (newly permits nowait) > "end target" > "end workshare" is ok, but: > and the following don't > > "end target parallel do simd" > "end target parallel do" > "end target parallel loop" (was completely missing before) > "end target teams distribute parallel do simd" > "end target teams distribute parallel do" The above 5 should allow it too. As per e.g. 5.2 [341:23], "The effect of the nowait clause is as if it is applied to the outermost leaf construct that permits it." so even for the above 5 the clause splitting should put nowait on target and not the others and be done with it. Jakub