From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTPS id 962CB385800F for ; Fri, 12 Nov 2021 19:49:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 962CB385800F Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-419-yVpd3a-BOJO7TN8LinmAzA-1; Fri, 12 Nov 2021 14:49:11 -0500 X-MC-Unique: yVpd3a-BOJO7TN8LinmAzA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E74D41015DA0; Fri, 12 Nov 2021 19:49:09 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.54]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 90DCB5D9D3; Fri, 12 Nov 2021 19:49:09 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 1ACJn6YP823942 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 12 Nov 2021 20:49:06 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 1ACJn59A823939; Fri, 12 Nov 2021 20:49:05 +0100 Date: Fri, 12 Nov 2021 20:49:05 +0100 From: Jakub Jelinek To: Alexander Monakov Cc: Tom de Vries , Tobias Burnus , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] libgomp, nvptx, v3: Honor OpenMP 5.1 num_teams lower bound Message-ID: <20211112194905.GA2664@tucnak> Reply-To: Jakub Jelinek References: <20211112132023.GC2710@tucnak> <20211112132716.GD2710@tucnak> <20211112175804.GJ2710@tucnak> <20211112194706.GL2710@tucnak> MIME-Version: 1.0 In-Reply-To: <20211112194706.GL2710@tucnak> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Nov 2021 19:49:14 -0000 On Fri, Nov 12, 2021 at 08:47:09PM +0100, Jakub Jelinek wrote: > The problem is that the argument of the num_teams clause isn't always known > before target is launched. There was a design mistake that the clause has been put on teams rather than on target (well, for host teams we need it on teams), and 5.1 actually partially fixes this up for thread_limit by allowing that clause on both, but not for num_teams. Jakub