From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id B4AA33857C42 for ; Mon, 15 Nov 2021 16:32:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B4AA33857C42 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-233-q4IktkQHNS-P8M2PSNzHRw-1; Mon, 15 Nov 2021 11:32:35 -0500 X-MC-Unique: q4IktkQHNS-P8M2PSNzHRw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7E7931023F4F for ; Mon, 15 Nov 2021 16:32:34 +0000 (UTC) Received: from abulafia.quesejoda.com (unknown [10.39.193.97]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 14C0C5C1BB; Mon, 15 Nov 2021 16:32:33 +0000 (UTC) Received: from abulafia.quesejoda.com (localhost [127.0.0.1]) by abulafia.quesejoda.com (8.16.1/8.15.2) with ESMTPS id 1AFGWV3i1236348 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 15 Nov 2021 17:32:31 +0100 Received: (from aldyh@localhost) by abulafia.quesejoda.com (8.16.1/8.16.1/Submit) id 1AFGWUv31236347; Mon, 15 Nov 2021 17:32:30 +0100 From: Aldy Hernandez To: GCC patches Subject: [COMMITTED] Drop tree overflow in irange setter. Date: Mon, 15 Nov 2021 17:32:28 +0100 Message-Id: <20211115163228.1236290-1-aldyh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-Spam-Status: No, score=-13.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Nov 2021 16:32:40 -0000 Drop meaningless overflow that may creep into the IL. Tested on x86-64 Linux. gcc/ChangeLog: PR tree-optimization/103207 * value-range.cc (irange::set): Drop overflow. gcc/testsuite/ChangeLog: * gcc.dg/pr103207.c: New test. --- gcc/testsuite/gcc.dg/pr103207.c | 15 +++++++++++++++ gcc/value-range.cc | 8 ++++++++ 2 files changed, 23 insertions(+) create mode 100644 gcc/testsuite/gcc.dg/pr103207.c diff --git a/gcc/testsuite/gcc.dg/pr103207.c b/gcc/testsuite/gcc.dg/pr103207.c new file mode 100644 index 00000000000..69c0f555f86 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr103207.c @@ -0,0 +1,15 @@ +// { dg-do compile } +// { dg-options "-O2 --param case-values-threshold=1 -w" } + +int f (int i) +{ + switch (i) { + case 2147483647: + return 1; + case 9223372036854775807L: + return 2; + case (2147483647*4)%4: + return 4; + } + return 0; +} diff --git a/gcc/value-range.cc b/gcc/value-range.cc index caef2498959..82509fa55a7 100644 --- a/gcc/value-range.cc +++ b/gcc/value-range.cc @@ -270,6 +270,14 @@ irange::irange_set_anti_range (tree min, tree max) void irange::set (tree min, tree max, value_range_kind kind) { + if (kind != VR_UNDEFINED) + { + if (TREE_OVERFLOW_P (min)) + min = drop_tree_overflow (min); + if (TREE_OVERFLOW_P (max)) + max = drop_tree_overflow (max); + } + if (!legacy_mode_p ()) { if (kind == VR_RANGE) -- 2.31.1