From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id 7EFA53858409 for ; Wed, 17 Nov 2021 20:01:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7EFA53858409 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 1AHK037B020720; Wed, 17 Nov 2021 14:00:03 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 1AHK02CN020719; Wed, 17 Nov 2021 14:00:02 -0600 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Wed, 17 Nov 2021 14:00:02 -0600 From: Segher Boessenkool To: "Paul A. Clarke" Cc: wschmidt@linux.ibm.com, GCC Patches , David Edelsohn Subject: Re: [PATCH] rs6000: Better error messages for power8/9-vector builtins Message-ID: <20211117200002.GT614@gate.crashing.org> References: <00061cd6-52e1-457d-5a7b-b5feac1c20f5@linux.ibm.com> <20211117165459.GA7755@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com> <1540c206-56b4-3f65-3477-43a7ecaec0c8@linux.ibm.com> <20211117174502.GB7755@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211117174502.GB7755@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com> User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Nov 2021 20:01:07 -0000 On Wed, Nov 17, 2021 at 11:45:02AM -0600, Paul A. Clarke wrote: > I guess I'm being pedantic. "requires -mcpu=power8 and -mvsx" is not > accurate from a user's point a view, as "-mcpu=power8" is sufficient, > since "-mvsx" is enabled when "-mcpu=power8" is specified. To be really pedantic, -mcpu=power8 isn't required either: anythng that enable the subset of ISA 2.07 that is needed is enough already. But we don't want to encourage users to use those interfaces. > The real "requires" is "-mcpu=power8" and no "-mno-vsx". And no -mno-altivec. And and and. There is a huge web. > It's not a strong objection, since specifying "-mno-vsx" should be > uncommon. (Right?) And, specifying "-mcpu=power8 -mvsx" is harmless. Maybe the warning could say "requires -mcpu=power8 (and -mvsx)"? Is that clearer, to your eye? Segher