From: Jan Hubicka <hubicka@kam.mff.cuni.cz>
To: "Martin Liška" <mliska@suse.cz>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] IPA: fix reproducibility in IPA MOD REF
Date: Thu, 18 Nov 2021 19:34:28 +0100 [thread overview]
Message-ID: <20211118183428.GH76860@kam.mff.cuni.cz> (raw)
In-Reply-To: <d27f0e55-6957-cdc2-c141-05771ac87e90@suse.cz>
> > >
> > > Isn't problem that the following code
> > >
> > > past_flags.reserve_exact (summary->arg_flags.length ());
> > > past_flags.splice (summary->arg_flags);
> > > past_retslot_flags = summary->retslot_flags;
> >
> > Aha, that makes sense. Sorry. It used to be saved for dumping only
> > while we now use it to merge old summaries with new. So it is indeed a
> > (quite stupid) bug.
>
> Good :) Good. I thought I overlooked something.
Hehe, I overlooked a hunk while breaking the patches into more
independent changes.
I planed a cleanup of this code after pushing out the new features.
Pehraps a trivial parts of the cleanup can be done even in stage3.
Honza
prev parent reply other threads:[~2021-11-18 18:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 17:58 Martin Liška
2021-11-18 18:11 ` Jan Hubicka
2021-11-18 18:16 ` Martin Liška
2021-11-18 18:22 ` Jan Hubicka
2021-11-18 18:27 ` Martin Liška
2021-11-18 18:29 ` Jan Hubicka
2021-11-18 18:31 ` Martin Liška
2021-11-18 18:34 ` Jan Hubicka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211118183428.GH76860@kam.mff.cuni.cz \
--to=hubicka@kam.mff.cuni.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).