From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 8B64B3858D28 for ; Tue, 23 Nov 2021 11:58:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8B64B3858D28 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-452-jXkIP2GzPPS2lpyO-TlvcA-1; Tue, 23 Nov 2021 06:58:25 -0500 X-MC-Unique: jXkIP2GzPPS2lpyO-TlvcA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 019D61023F52; Tue, 23 Nov 2021 11:58:24 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 84C875C1D5; Tue, 23 Nov 2021 11:58:23 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 1ANBwKWg2106313 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 23 Nov 2021 12:58:21 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 1ANBwJjc2106312; Tue, 23 Nov 2021 12:58:19 +0100 Date: Tue, 23 Nov 2021 12:58:19 +0100 From: Jakub Jelinek To: Siddhesh Poyarekar , gcc-patches@gcc.gnu.org Subject: Re: [PATCH 03/10] tree-object-size: Use tree instead of HOST_WIDE_INT Message-ID: <20211123115819.GU2646553@tucnak> Reply-To: Jakub Jelinek References: <20211109190137.1107736-1-siddhesh@gotplt.org> <20211109190137.1107736-4-siddhesh@gotplt.org> <20211119170639.GT2646553@tucnak> <7915f97c-54ca-1d23-506a-bc916620c12a@gotplt.org> <20211122103150.GL2646553@tucnak> <1468e98c-7834-b6eb-593d-53bfa1430f83@gotplt.org> <20211122123222.GM2646553@tucnak> MIME-Version: 1.0 In-Reply-To: <20211122123222.GM2646553@tucnak> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Nov 2021 11:58:27 -0000 On Mon, Nov 22, 2021 at 01:32:22PM +0100, Jakub Jelinek via Gcc-patches wrote: > On Mon, Nov 22, 2021 at 06:01:08PM +0530, Siddhesh Poyarekar wrote: > > On 11/22/21 17:30, Siddhesh Poyarekar wrote: > > > So I've got patch 10/10, which handles dynamic (and consequently > > > negative) offsets.  It basically computes a "whole size", which then > > > gives the extent to which a negative offset is valid, making the > > > estimates a bit more precise.  I didn't do it for static object sizes > > > because I didn't have time then, but I could add a patch 11/10 if the > > > idea sounds OK to you. > > > > ... or alternatively, I could bring the whole size idea into this tree > > conversion patch so that it handles all kinds of offsets. That might even > > eliminate patch 10/10. What would you prefer? > > Into this patch. BTW, seems the current behavior is to punt on those "negative" values, we trigger if (offset >= offset_limit) case for it and return unknown. Jakub