From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id CC19C3857C6E for ; Tue, 23 Nov 2021 14:00:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CC19C3857C6E Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-374-DMY2S3BtNZKHOVe72z2DLA-1; Tue, 23 Nov 2021 09:00:06 -0500 X-MC-Unique: DMY2S3BtNZKHOVe72z2DLA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4EF091966320; Tue, 23 Nov 2021 14:00:05 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B2858100760F; Tue, 23 Nov 2021 14:00:04 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 1ANE01pK2108630 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 23 Nov 2021 15:00:01 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 1ANE00p02108629; Tue, 23 Nov 2021 15:00:00 +0100 Date: Tue, 23 Nov 2021 15:00:00 +0100 From: Jakub Jelinek To: Siddhesh Poyarekar Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 05/10] __builtin_dynamic_object_size: Recognize builtin Message-ID: <20211123140000.GX2646553@tucnak> Reply-To: Jakub Jelinek References: <20211109190137.1107736-1-siddhesh@gotplt.org> <20211109190137.1107736-6-siddhesh@gotplt.org> <20211123124149.GW2646553@tucnak> <8034fc39-9efc-30f8-6abe-f61f2bc30fbb@gotplt.org> MIME-Version: 1.0 In-Reply-To: <8034fc39-9efc-30f8-6abe-f61f2bc30fbb@gotplt.org> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Nov 2021 14:00:12 -0000 On Tue, Nov 23, 2021 at 07:23:01PM +0530, Siddhesh Poyarekar wrote: > > What's the advantage of another argument and then merging it with > > object_size_type over just passing object_size_type which will have > > all the bits in? > > I kept the size bits as an internal detail, I can define them in > tree-object-size.h and hae builtins.c (and others) use them. Good idea. Jakub