From: Raoni Fassina Firmino <raoni@linux.ibm.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org, segher@kernel.crashing.org,
jakub@redhat.com, rguenther@suse.de, hp@bitrange.com,
law@redhat.com, will_schmidt@vnet.ibm.com
Subject: Re: [PATCH v6] rtl: builtins: (not just) rs6000: Add builtins for fegetround, feclearexcept and feraiseexcept [PR94193]
Date: Wed, 24 Nov 2021 17:22:57 -0300 [thread overview]
Message-ID: <20211124202257.qhecwwcblgihby3b@work-tp> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2110181538130.114463@digraph.polyomino.org.uk>
Hi Joseph,
Thanks for the detailed review and explanations.
On Mon, Oct 18, 2021 at 03:54:53PM +0000, Joseph Myers wrote:
> However, it's better to get things right automatically without needing any
> macros or other header additions at all. That is, define feclearexcept as
> a built-in function, *without* the extra arguments, and with the back end
> knowing about the FE_* values for the target libc. Then you can simply
> avoid expanding the function inline when the back end doesn't know both
> the FE_* values and how to use them.
I took this part to heart, I agree that an approach in molds of the v5
sounds more like it, something that will "just works" or fallback
gracefully. And who knew, with your insight I think I find just
the thing, I am finishing a v7 and I hope it address the previews
consernings and sidestep all this complications with the v6 aproach.
o/
Raoni
next prev parent reply other threads:[~2021-11-24 20:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-17 0:04 Raoni Fassina Firmino
2021-10-18 15:54 ` Joseph Myers
2021-11-24 20:22 ` Raoni Fassina Firmino [this message]
2021-11-24 21:32 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211124202257.qhecwwcblgihby3b@work-tp \
--to=raoni@linux.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hp@bitrange.com \
--cc=jakub@redhat.com \
--cc=joseph@codesourcery.com \
--cc=law@redhat.com \
--cc=rguenther@suse.de \
--cc=segher@kernel.crashing.org \
--cc=will_schmidt@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).