From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 6057F3857814 for ; Wed, 24 Nov 2021 20:23:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6057F3857814 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1AOK5fqO011561; Wed, 24 Nov 2021 20:23:06 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 3chs9km1v6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Nov 2021 20:23:06 +0000 Received: from m0098419.ppops.net (m0098419.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 1AOJVMYK010574; Wed, 24 Nov 2021 20:23:06 GMT Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0b-001b2d01.pphosted.com with ESMTP id 3chs9km1ux-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Nov 2021 20:23:06 +0000 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 1AOKH8LS002909; Wed, 24 Nov 2021 20:23:05 GMT Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by ppma04dal.us.ibm.com with ESMTP id 3cerncddrx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Nov 2021 20:23:05 +0000 Received: from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com [9.57.199.111]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 1AOKN4Rq46399822 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Nov 2021 20:23:04 GMT Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 87712AC065; Wed, 24 Nov 2021 20:23:04 +0000 (GMT) Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3BC4BAC05F; Wed, 24 Nov 2021 20:23:01 +0000 (GMT) Received: from work-tp (unknown [9.65.226.233]) by b01ledav006.gho.pok.ibm.com (Postfix) with ESMTPS; Wed, 24 Nov 2021 20:23:00 +0000 (GMT) Date: Wed, 24 Nov 2021 17:22:57 -0300 From: Raoni Fassina Firmino To: Joseph Myers Cc: gcc-patches@gcc.gnu.org, segher@kernel.crashing.org, jakub@redhat.com, rguenther@suse.de, hp@bitrange.com, law@redhat.com, will_schmidt@vnet.ibm.com Subject: Re: [PATCH v6] rtl: builtins: (not just) rs6000: Add builtins for fegetround, feclearexcept and feraiseexcept [PR94193] Message-ID: <20211124202257.qhecwwcblgihby3b@work-tp> Mail-Followup-To: Joseph Myers , gcc-patches@gcc.gnu.org, segher@kernel.crashing.org, jakub@redhat.com, rguenther@suse.de, hp@bitrange.com, law@redhat.com, will_schmidt@vnet.ibm.com References: <20211017000415.vqt5yyrq7j7kg5c4@work-tp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: jXx4h7aq3bd3XHsIvxj_Svr19aSAw6yO X-Proofpoint-GUID: MVZgxfUoT4rdmzPV5Z0_ajexMpwgKSZi X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-24_06,2021-11-24_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 mlxscore=0 adultscore=0 mlxlogscore=570 suspectscore=0 priorityscore=1501 impostorscore=0 phishscore=0 bulkscore=0 clxscore=1011 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2111240102 X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Nov 2021 20:23:11 -0000 Hi Joseph, Thanks for the detailed review and explanations. On Mon, Oct 18, 2021 at 03:54:53PM +0000, Joseph Myers wrote: > However, it's better to get things right automatically without needing any > macros or other header additions at all. That is, define feclearexcept as > a built-in function, *without* the extra arguments, and with the back end > knowing about the FE_* values for the target libc. Then you can simply > avoid expanding the function inline when the back end doesn't know both > the FE_* values and how to use them. I took this part to heart, I agree that an approach in molds of the v5 sounds more like it, something that will "just works" or fallback gracefully. And who knew, with your insight I think I find just the thing, I am finishing a v7 and I hope it address the previews consernings and sidestep all this complications with the v6 aproach. o/ Raoni