Re: [PATCH, committed] rs6000: Fix test_mffsl.c effective target check

[Segher Boessenkool <segher@kernel.crashing.org>]

Hi!

On Tue, Nov 23, 2021 at 01:14:05PM -0600, Bill Schmidt wrote:
> Paul Clarke pointed out to me that I had wrongly used a compile-time check
> instead of a run-time check in this executable test.  This patch fixes
> that.  I also fixed a typo in a string that caught my eye.
> 
> Tested on powerpc64le-linux-gnu, committed as obvious.

Thanks.

> --- a/gcc/testsuite/gcc.target/powerpc/test_mffsl.c
> +++ b/gcc/testsuite/gcc.target/powerpc/test_mffsl.c
> @@ -1,6 +1,6 @@
>  /* { dg-do run { target { powerpc*-*-* } } } */

(The target clause is redundant fwiw, feel free to remove it).

>  /* { dg-options "-O2 -std=c99 -mcpu=power9" } */
> -/* { dg-require-effective-target powerpc_p9vector_ok } */
> +/* { dg-require-effective-target p9vector_hw } */

This selector doesn't make too much sense, since nothing in here
requires vectors at all.  p9modulo_hw makes more sense.  Except the
name of that should just be power9_hw :-)

The OS can disallow vector insns (MSR[VEC] and/or MSR[VSX]), so
p9vector_hw tests it isn't doing that, and that the hardware is a p9.
p9modulo_hw does only the latter, and we have no reason to check
separately if we can run modulo insns anyway :-)

So please change the test here.  And bonus points if you can rename
p9modulo_hw and _ok (in a separate patch of course).


Segher