From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 307183858C3A for ; Fri, 26 Nov 2021 18:01:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 307183858C3A Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-31-LcZvPam1N4SzBBx85oIRhg-1; Fri, 26 Nov 2021 13:01:11 -0500 X-MC-Unique: LcZvPam1N4SzBBx85oIRhg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 802D91853022; Fri, 26 Nov 2021 18:01:10 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 128416C350; Fri, 26 Nov 2021 18:01:09 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 1AQI17gZ3987244 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 26 Nov 2021 19:01:07 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 1AQI16Ij3987243; Fri, 26 Nov 2021 19:01:06 +0100 Date: Fri, 26 Nov 2021 19:01:06 +0100 From: Jakub Jelinek To: Siddhesh Poyarekar Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH v3 1/8] tree-object-size: Replace magic numbers with enums Message-ID: <20211126180106.GN2646553@tucnak> Reply-To: Jakub Jelinek References: <20211109190137.1107736-1-siddhesh@gotplt.org> <20211126052851.2176408-1-siddhesh@gotplt.org> <20211126052851.2176408-2-siddhesh@gotplt.org> <20211126164629.GK2646553@tucnak> <96affcdc-b1ff-6481-716e-1d7331b801f0@gotplt.org> MIME-Version: 1.0 In-Reply-To: <96affcdc-b1ff-6481-716e-1d7331b801f0@gotplt.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Nov 2021 18:01:17 -0000 On Fri, Nov 26, 2021 at 11:23:31PM +0530, Siddhesh Poyarekar wrote: > On 11/26/21 22:16, Jakub Jelinek wrote: > > On Fri, Nov 26, 2021 at 10:58:44AM +0530, Siddhesh Poyarekar wrote: > > > A simple cleanup to allow inserting dynamic size code more easily. > > > > > > gcc/ChangeLog: > > > > > > * tree-object-size.c: New enum. > > > (object_sizes, computed, addr_object_size, > > > compute_builtin_object_size, expr_object_size, call_object_size, > > > merge_object_sizes, plus_stmt_object_size, > > > collect_object_sizes_for, init_object_sizes, fini_object_sizes, > > > object_sizes_execute): Replace magic numbers with enums. > > > > > > Signed-off-by: Siddhesh Poyarekar > > > > Ok, thanks. > > Thanks, may I push these patches since they're independent cleanups? The first two, yes. Jakub