From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id AC06D3858D39 for ; Fri, 26 Nov 2021 18:04:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AC06D3858D39 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-30-x8-GcXK2PaWJnlr3o1zP9A-1; Fri, 26 Nov 2021 13:04:33 -0500 X-MC-Unique: x8-GcXK2PaWJnlr3o1zP9A-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 381E81853022; Fri, 26 Nov 2021 18:04:32 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B472660854; Fri, 26 Nov 2021 18:04:31 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 1AQI4SW23987289 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 26 Nov 2021 19:04:29 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 1AQI4Shc3987288; Fri, 26 Nov 2021 19:04:28 +0100 Date: Fri, 26 Nov 2021 19:04:28 +0100 From: Jakub Jelinek To: Siddhesh Poyarekar Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH v3 3/8] tree-object-size: Save sizes as trees and support negative offsets Message-ID: <20211126180428.GO2646553@tucnak> Reply-To: Jakub Jelinek References: <20211109190137.1107736-1-siddhesh@gotplt.org> <20211126052851.2176408-1-siddhesh@gotplt.org> <20211126052851.2176408-4-siddhesh@gotplt.org> <20211126165634.GM2646553@tucnak> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Nov 2021 18:04:36 -0000 On Fri, Nov 26, 2021 at 11:29:41PM +0530, Siddhesh Poyarekar wrote: > > > The trees in object_sizes are each a TREE_VEC with the first element > > > being the bytes from the pointer to the end of the object and the > > > second, the size of the whole object. This allows analysis of negative > > > offsets, which can now be allowed to the extent of the object bounds. > > > Tests have been added to verify that it actually works. > > > > If you need pairs of trees, just use pairs of trees, using TREE_VEC for it > > will create lots of extra garbage. > > Either std::pair, but most likely gengtype won't handle that > > right, so just create your own > > struct GTY(()) whatever { > > /* Comment explaining what it is. */ > > tree whatever1; > > /* Comment explaining what it is. */ > > tree whatever2; > > }; > > and if that needs to go into e.g. object_sizes vectors, use vec. > > Got it, I'll make a new struct GTY(()). I'm also using TREE_VEC to store > PHI nodes args and the result (in patch 5/8) until they're emitted in > gimplify_size_expressions. It needs to be a tree since it would be stored > in whatever1 and whatever2, would that be acceptable use? Maybe yes, I'll need to look at it. What I didn't like is using TREE_VEC for something that will come in pairs all the time. Jakub