From: Aldy Hernandez <aldyh@redhat.com>
To: Richard Biener <richard.guenther@gmail.com>
Cc: GCC patches <gcc-patches@gcc.gnu.org>,
Andrew MacLeod <amacleod@redhat.com>,
Aldy Hernandez <aldyh@redhat.com>
Subject: [PATCH] Remove can_throw_non_call_exceptions special case from operator_div::wi_fold.
Date: Mon, 29 Nov 2021 15:00:50 +0100 [thread overview]
Message-ID: <20211129140050.82907-1-aldyh@redhat.com> (raw)
As discussed in the PR. The code makes no difference, so whatever test
we added this special case for has been fixed or is being papered over.
I think we should fix any fall out upstream.
[Unless Andrew can remember why we added this and it still applies.]
Tested on x86-64 Linux.
OK for trunk?
PR 103451
gcc/ChangeLog:
* range-op.cc (operator_div::wi_fold): Remove
can_throw_non_call_exceptions special case.
gcc/testsuite/ChangeLog:
* gcc.dg/pr103451.c: New test.
---
gcc/range-op.cc | 7 -------
gcc/testsuite/gcc.dg/pr103451.c | 17 +++++++++++++++++
2 files changed, 17 insertions(+), 7 deletions(-)
create mode 100644 gcc/testsuite/gcc.dg/pr103451.c
diff --git a/gcc/range-op.cc b/gcc/range-op.cc
index bbf2924f815..6fe5f1cb4e0 100644
--- a/gcc/range-op.cc
+++ b/gcc/range-op.cc
@@ -1832,13 +1832,6 @@ operator_div::wi_fold (irange &r, tree type,
return;
}
- // If flag_non_call_exceptions, we must not eliminate a division by zero.
- if (cfun->can_throw_non_call_exceptions)
- {
- r.set_varying (type);
- return;
- }
-
// If we're definitely dividing by zero, there's nothing to do.
if (wi_zero_p (type, divisor_min, divisor_max))
{
diff --git a/gcc/testsuite/gcc.dg/pr103451.c b/gcc/testsuite/gcc.dg/pr103451.c
new file mode 100644
index 00000000000..b83646d0b83
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr103451.c
@@ -0,0 +1,17 @@
+// { dg-do compile }
+// { dg-options "-O2 -w" }
+
+int func_10_ptr_12;
+
+void func_10(long li_8)
+{
+ long *ptr_9 = &li_8;
+ li_8 &= *ptr_9 / 0 ?: li_8;
+ for (;;)
+ func_10_ptr_12 &= 4 ? *ptr_9 : 4;
+}
+
+void func_9_s_8()
+{
+ func_10(func_9_s_8);
+}
--
2.31.1
next reply other threads:[~2021-11-29 14:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 14:00 Aldy Hernandez [this message]
2021-11-29 14:39 ` Jeff Law
2021-11-29 14:48 ` Richard Biener
2021-11-29 15:24 ` Aldy Hernandez
2021-11-30 7:37 ` Richard Biener
2021-11-30 8:51 ` Aldy Hernandez
2021-11-30 9:00 ` Richard Biener
2021-11-30 9:04 ` Aldy Hernandez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211129140050.82907-1-aldyh@redhat.com \
--to=aldyh@redhat.com \
--cc=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).