public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: "Kewen.Lin" <linkw@linux.ibm.com>
Cc: wschmidt@linux.ibm.com, David Edelsohn <dje.gcc@gmail.com>,
	bergner@linux.ibm.com, GCC Patches <gcc-patches@gcc.gnu.org>,
	will schmidt <will_schmidt@vnet.ibm.com>,
	Richard Biener <richard.guenther@gmail.com>
Subject: Re: [PATCH] rs6000: Remove builtin mask check from builtin_decl [PR102347]
Date: Mon, 29 Nov 2021 18:07:11 -0600	[thread overview]
Message-ID: <20211130000711.GX614@gate.crashing.org> (raw)
In-Reply-To: <8defa60f-4192-1064-fcd3-d9a752d37aae@linux.ibm.com>

Hi!

On Mon, Oct 11, 2021 at 02:30:42PM +0800, Kewen.Lin wrote:
> > If we do need a band-aid for 10 and 11 (and we do as far as I can see),
> > I'd like to see one for just MMA there, and let all other badness fade
> > into history.  Unless you can convince me (in the patch / commit
> > message) that this is safe :-)
> 
> Just to fix for MMA seems incomplete to me since we can simply
> construct one non-MMA but failed case.  I questioned in the other
> thread, is there any possibility for one invalid target specific
> bif to escape from the function rs6000_expand_builtin?  (note that
> folding won't handle invalid bifs, so invalid bifs won't get folded
> early.)  If no, I think it would be safe.

It is much safer and simpler to not backport anything we do not need to.
You need to come up with a reason why it would be a good idea to do
backport something, especially if it isn't obviously super safe.


Segher

  parent reply	other threads:[~2021-11-30  0:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-28  8:13 Kewen.Lin
2021-09-28 19:24 ` Bill Schmidt
2021-09-29  0:25   ` Peter Bergner
2021-09-29  2:34   ` Kewen.Lin
2021-09-29 11:59     ` Bill Schmidt
2021-09-30  3:06       ` Kewen.Lin
2021-09-30 22:13         ` Segher Boessenkool
2021-10-11  6:30           ` Kewen.Lin
2021-10-12 16:36             ` Bill Schmidt
2021-10-13  3:25               ` Kewen.Lin
2021-11-30  0:07             ` Segher Boessenkool [this message]
2021-10-20  9:35 ` PING^1 " Kewen.Lin
2021-11-04 10:58   ` PING^2 " Kewen.Lin
2021-11-22  2:25     ` PING^3 " Kewen.Lin
2021-11-30  0:16 ` Segher Boessenkool
2021-11-30  4:54   ` Kewen.Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211130000711.GX614@gate.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=bergner@linux.ibm.com \
    --cc=dje.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=linkw@linux.ibm.com \
    --cc=richard.guenther@gmail.com \
    --cc=will_schmidt@vnet.ibm.com \
    --cc=wschmidt@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).