From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id 0A3993858402 for ; Tue, 30 Nov 2021 00:08:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0A3993858402 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 1AU07BbQ025917; Mon, 29 Nov 2021 18:07:17 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 1AU07BnV025916; Mon, 29 Nov 2021 18:07:11 -0600 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Mon, 29 Nov 2021 18:07:11 -0600 From: Segher Boessenkool To: "Kewen.Lin" Cc: wschmidt@linux.ibm.com, David Edelsohn , bergner@linux.ibm.com, GCC Patches , will schmidt , Richard Biener Subject: Re: [PATCH] rs6000: Remove builtin mask check from builtin_decl [PR102347] Message-ID: <20211130000711.GX614@gate.crashing.org> References: <7505a666-7b51-255c-9908-aabc753f7c33@linux.ibm.com> <62e6c096-f4a0-dc25-edba-ba0f32179438@linux.ibm.com> <10dc76e1-cf19-acc4-bb43-871ea87d3363@linux.ibm.com> <20210930221350.GI22689@gate.crashing.org> <8defa60f-4192-1064-fcd3-d9a752d37aae@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8defa60f-4192-1064-fcd3-d9a752d37aae@linux.ibm.com> User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Nov 2021 00:08:26 -0000 Hi! On Mon, Oct 11, 2021 at 02:30:42PM +0800, Kewen.Lin wrote: > > If we do need a band-aid for 10 and 11 (and we do as far as I can see), > > I'd like to see one for just MMA there, and let all other badness fade > > into history. Unless you can convince me (in the patch / commit > > message) that this is safe :-) > > Just to fix for MMA seems incomplete to me since we can simply > construct one non-MMA but failed case. I questioned in the other > thread, is there any possibility for one invalid target specific > bif to escape from the function rs6000_expand_builtin? (note that > folding won't handle invalid bifs, so invalid bifs won't get folded > early.) If no, I think it would be safe. It is much safer and simpler to not backport anything we do not need to. You need to come up with a reason why it would be a good idea to do backport something, especially if it isn't obviously super safe. Segher