From: Segher Boessenkool <segher@kernel.crashing.org>
To: Bill Schmidt <wschmidt@linux.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
David Edelsohn <dje.gcc@gmail.com>
Subject: Re: [PATCH] rs6000: Builtins test changes for BFP scalar tests
Date: Wed, 1 Dec 2021 15:29:52 -0600 [thread overview]
Message-ID: <20211201212952.GG614@gate.crashing.org> (raw)
In-Reply-To: <585a2224-e076-9d26-921b-6db56f1606b9@linux.ibm.com>
On Wed, Nov 17, 2021 at 02:58:54PM -0600, Bill Schmidt wrote:
> Hi! This patch is broken out of the previous patch for all the builtins test
> suite adjustments. Here we have some slight changes in error messages due to
> how the internals have changed between the old and new builtins methods.
>
> For scalar-extract-exp-2.c we change:
> error: '__builtin_vec_scalar_extract_exp is not supported in this compiler configuration'
>
> to:
> error: '__builtin_vsx_scalar_extract_exp' requires the '-mcpu=power9' option and either the '-m64' or '-mpowerpc64' option
> note: builtin '__builtin_vec_scalar_extract_exp' requires builtin '__builtin_vsx_scalar_extract_exp'
So, okay for trunk. Thanks!
One thing though:
> gcc/testsuite/
> * gcc.target/powerpc/bfp/scalar-extract-exp-2.c: Adjust error
> message.
Don't wrap unnecessarily please.
> * gcc.target/powerpc/bfp/scalar-extract-sig-2.c: Likewise.
> * gcc.target/powerpc/bfp/scalar-insert-exp-2.c: Likewise.
> * gcc.target/powerpc/bfp/scalar-insert-exp-5.c: Likewise.
> * gcc.target/powerpc/bfp/scalar-insert-exp-8.c: Likewise.
> * gcc.target/powerpc/bfp/scalar-test-neg-2.c: Likewise.
> * gcc.target/powerpc/bfp/scalar-test-neg-3.c: Likewise.
> * gcc.target/powerpc/bfp/scalar-test-neg-5.c: Likewise.
Segher
prev parent reply other threads:[~2021-12-01 21:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 20:58 Bill Schmidt
2021-11-17 21:32 ` Segher Boessenkool
2021-11-17 23:06 ` Bill Schmidt
2021-11-18 13:32 ` Bill Schmidt
2021-11-18 21:18 ` Segher Boessenkool
2021-11-18 21:16 ` Segher Boessenkool
2021-11-18 21:30 ` Bill Schmidt
2021-11-18 21:32 ` Segher Boessenkool
2021-11-18 21:59 ` Bill Schmidt
2021-12-01 21:16 ` Segher Boessenkool
2021-12-01 16:31 ` [PATCH, PING] " Bill Schmidt
2021-12-01 21:29 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211201212952.GG614@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).