* [PATCH v2] regrename: Skip renaming if instruction is noop move.
@ 2021-12-03 3:35 Jojo R
0 siblings, 0 replies; 5+ messages in thread
From: Jojo R @ 2021-12-03 3:35 UTC (permalink / raw)
To: rjiejie, gcc-patches, jeffreyalaw, richard.guenther, kito.cheng
Skip renaming if instruction is noop move, and it will
been removed for performance.
gcc/
* regrename.c (find_rename_reg): Return satisfied regno
if instruction is noop move.
---
gcc/regrename.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/gcc/regrename.c b/gcc/regrename.c
index b8a9ca36f22..fe72fcc3624 100644
--- a/gcc/regrename.c
+++ b/gcc/regrename.c
@@ -394,6 +394,11 @@ find_rename_reg (du_head_p this_head, enum reg_class super_class,
this_head, *unavailable))
return this_head->tied_chain->regno;
+ /* If this insn is a noop move, then do not rename in this chain as doing so
+ would inhibit removal of the noop move. */
+ if (noop_move_p (this_head->first->insn))
+ return best_new_reg;
+
/* If PREFERRED_CLASS is not NO_REGS, we iterate in the first pass
over registers that belong to PREFERRED_CLASS and try to find the
best register within the class. If that failed, we iterate in
--
2.24.3 (Apple Git-128)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] regrename: Skip renaming if instruction is noop move.
2021-12-14 1:40 ` Jojo R
@ 2021-12-14 21:56 ` Jeff Law
0 siblings, 0 replies; 5+ messages in thread
From: Jeff Law @ 2021-12-14 21:56 UTC (permalink / raw)
To: Jojo R, gcc-patches, richard.guenther, kito.cheng
On 12/13/2021 6:40 PM, Jojo R wrote:
> Hi,
>
> Thank you for your review & help.
>
> I could not fetch the merged patch from gcc master of git.
>
> Is there any problem for this ?
I assumed you'd commit the change. I thought you had commit
privileges. I'll go ahead and push it momentarily.
Thanks for following up.
Jeff
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] regrename: Skip renaming if instruction is noop move.
2021-12-03 14:57 ` Jeff Law
@ 2021-12-14 1:40 ` Jojo R
2021-12-14 21:56 ` Jeff Law
0 siblings, 1 reply; 5+ messages in thread
From: Jojo R @ 2021-12-14 1:40 UTC (permalink / raw)
To: gcc-patches, richard.guenther, kito.cheng, Jeff Law
Hi,
Thank you for your review & help.
I could not fetch the merged patch from gcc master of git.
Is there any problem for this ?
Thanks.
— Jojo
在 2021年12月3日 +0800 PM10:57,Jeff Law <jeffreyalaw@gmail.com>,写道:
>
>
> On 12/2/2021 9:26 PM, Jojo R wrote:
> > Skip renaming if instruction is noop move, and it will
> > been removed for performance.
> >
> > gcc/
> > * regrename.c (find_rename_reg): Return satisfied regno
> > if instruction is noop move.
> OK
> jeff
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] regrename: Skip renaming if instruction is noop move.
2021-12-03 4:26 ` [PATCH v2] " Jojo R
@ 2021-12-03 14:57 ` Jeff Law
2021-12-14 1:40 ` Jojo R
0 siblings, 1 reply; 5+ messages in thread
From: Jeff Law @ 2021-12-03 14:57 UTC (permalink / raw)
To: Jojo R, gcc-patches, richard.guenther, kito.cheng
On 12/2/2021 9:26 PM, Jojo R wrote:
> Skip renaming if instruction is noop move, and it will
> been removed for performance.
>
> gcc/
> * regrename.c (find_rename_reg): Return satisfied regno
> if instruction is noop move.
OK
jeff
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] regrename: Skip renaming if instruction is noop move.
2021-12-02 18:24 [PATCH] " Jeff Law
@ 2021-12-03 4:26 ` Jojo R
2021-12-03 14:57 ` Jeff Law
0 siblings, 1 reply; 5+ messages in thread
From: Jojo R @ 2021-12-03 4:26 UTC (permalink / raw)
To: rjiejie, gcc-patches, jeffreyalaw, richard.guenther, kito.cheng
Skip renaming if instruction is noop move, and it will
been removed for performance.
gcc/
* regrename.c (find_rename_reg): Return satisfied regno
if instruction is noop move.
---
gcc/regrename.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/gcc/regrename.c b/gcc/regrename.c
index b8a9ca36f22..fe72fcc3624 100644
--- a/gcc/regrename.c
+++ b/gcc/regrename.c
@@ -394,6 +394,11 @@ find_rename_reg (du_head_p this_head, enum reg_class super_class,
this_head, *unavailable))
return this_head->tied_chain->regno;
+ /* If this insn is a noop move, then do not rename in this chain as doing so
+ would inhibit removal of the noop move. */
+ if (noop_move_p (this_head->first->insn))
+ return best_new_reg;
+
/* If PREFERRED_CLASS is not NO_REGS, we iterate in the first pass
over registers that belong to PREFERRED_CLASS and try to find the
best register within the class. If that failed, we iterate in
--
2.24.3 (Apple Git-128)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-12-14 21:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-03 3:35 [PATCH v2] regrename: Skip renaming if instruction is noop move Jojo R
-- strict thread matches above, loose matches on Subject: below --
2021-12-02 18:24 [PATCH] " Jeff Law
2021-12-03 4:26 ` [PATCH v2] " Jojo R
2021-12-03 14:57 ` Jeff Law
2021-12-14 1:40 ` Jojo R
2021-12-14 21:56 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).