From: Segher Boessenkool <segher@kernel.crashing.org>
To: Bill Schmidt <wschmidt@linux.ibm.com>
Cc: gcc-patches@gcc.gnu.org, dje.gcc@gmail.com
Subject: Re: [PATCH 1/6] rs6000: Remove new_builtins_are_live and dead code it was guarding
Date: Mon, 6 Dec 2021 19:09:51 -0600 [thread overview]
Message-ID: <20211207010951.GR614@gate.crashing.org> (raw)
In-Reply-To: <2fe5f305b9f6b712dc0b12a1aab1d8ed6727e14d.1638820430.git.wschmidt@linux.ibm.com>
Hi!
On Mon, Dec 06, 2021 at 02:49:03PM -0600, Bill Schmidt wrote:
> To allow for a sane switch-over from the old built-in infrastructure to the
> new, both sets of code have co-existed, with the enabled one under the control
> of the boolean variable new_builtins_are_live. As a first step in removing the
> old code, remove this variable and the now-dead code it was guarding.
> * config/rs6000/darwin.h (SUBTARGET_INIT_BUILTINS): Remove
> test for new_builtins_are_live and simplify.
Please don't terminate changelog lines early.
> * config/rs6000/rs6000-c.c (altivec_build_resolved_builtin): Remove
> dead function.
Same here, but you may want to keep line length 79 instead of 80, some
people like that for some reason.
> (altivec_resolve_overloaded_builtin): Remove test for
> new_builtins_are_live and simplify.
> * config/rs6000/rs6000-call.c (altivec_init_builtins): Remove forward
> declaration.
> (builtin_function_type): Likewise.
> (rs6000_common_init_builtins): Likewise.
> (htm_init_builtins): Likewise.
> (mma_init_builtins): Likewise.
> (def_builtin): Remove dead function.
> (rs6000_expand_zeroop_builtin): Likewise.
> (rs6000_expand_mtfsf_builtin): Likewise.
> (rs6000_expand_mtfsb_builtin): Likewise.
> (rs6000_expand_set_fpscr_rn_builtin): Likewise.
> (rs6000_expand_set_fpscr_drn_builtin): Likewise.
> (rs6000_expand_unop_builtin): Likewise.
> (altivec_expand_abs_builtin): Likewise.
> (rs6000_expand_binop_builtin): Likewise.
> (altivec_expand_lxvr_builtin): Likewise.
> (altivec_expand_lv_builtin): Likewise.
> (altivec_expand_stxvl_builtin): Likewise.
> (altivec_expand_stv_builtin): Likewise.
> (mma_expand_builtin): Likewise.
> (htm_expand_builtin): Likewise.
> (cpu_expand_builtin): Likewise.
> (rs6000_expand_quaternop_builtin): Likewise.
> (rs6000_expand_ternop_builtin): Likewise.
> (altivec_expand_dst_builtin): Likewise.
> (altivec_expand_vec_sel_builtin): Likewise.
> (altivec_expand_builtin): Likewise.
> (rs6000_invalid_builtin): Likewise.
> (rs6000_builtin_valid_without_lhs): Likewise.
> (rs6000_gimple_fold_builtin): Remove test for new_builtins_are_live and
> simplify.
> (rs6000_expand_builtin): Likewise.
> (rs6000_init_builtins): Remove tests for new_builtins_are_live and
> simplify.
> (rs6000_builtin_decl): Likewise.
> (altivec_init_builtins): Remove dead function.
> (mma_init_builtins): Likewise.
> (htm_init_builtins): Likewise.
> (builtin_quaternary_function_type): Likewise.
> (builtin_function_type): Likewise.
> (rs6000_common_init_builtins): Likewise.
> * config/rs6000/rs6000-gen-builtins.c (write_header_file): Don't
> declare new_builtins_are_live.
> (write_init_bif_table): In generated code, remove test for
> new_builtins_are_live and simplify.
> (write_init_ovld_table): Likewise.
> (write_init_file): Don't initialize new_builtins_are_live.
> * config/rs6000/rs6000.c (rs6000_builtin_vectorized_function): Remove
> test for new_builtins_are_live and simplify.
> (rs6000_builtin_md_vectorized_function): Likewise.
> (rs6000_builtin_reciprocal): Likewise.
> (add_condition_to_bb): Likewise.
> (rs6000_atomic_assign_expand_fenv): Likewise.
You could have said "Remove old builtins code." everywhere ;-)
Okay for trunk. Thanks!
Segher
next prev parent reply other threads:[~2021-12-07 1:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 20:49 [PATCH v2 0/6] Remove "old" built-in function infrastructure Bill Schmidt
2021-12-06 20:49 ` [PATCH 1/6] rs6000: Remove new_builtins_are_live and dead code it was guarding Bill Schmidt
2021-12-07 1:09 ` Segher Boessenkool [this message]
2021-12-06 20:49 ` [PATCH 2/6] rs6000: Remove altivec_overloaded_builtins array and initialization Bill Schmidt
2021-12-14 17:57 ` [PATCH v2 " Bill Schmidt
2021-12-14 18:04 ` [PATCH " David Edelsohn
2021-12-06 20:49 ` [PATCH 3/6] rs6000: Rename rs6000-builtin-new.def to rs6000-builtins.def Bill Schmidt
2021-12-14 18:00 ` [PATCH v2 " Bill Schmidt
2021-12-14 18:05 ` [PATCH " David Edelsohn
2021-12-06 20:49 ` [PATCH 4/6] rs6000: Remove rs6000-builtin.def and associated data and functions Bill Schmidt
2021-12-14 18:00 ` [PATCH v2 " Bill Schmidt
2021-12-14 18:08 ` [PATCH " David Edelsohn
2021-12-06 20:49 ` [PATCH 5/6] rs6000: Rename functions with "new" in their names Bill Schmidt
2021-12-14 18:01 ` [PATCH v2 /6] " Bill Schmidt
2021-12-14 18:08 ` [PATCH 5/6] " David Edelsohn
2021-12-06 20:49 ` [PATCH 6/6] rs6000: Rename arrays to remove temporary _x suffix Bill Schmidt
2021-12-14 18:01 ` [PATCH v2 " Bill Schmidt
2021-12-14 18:10 ` [PATCH " David Edelsohn
2021-12-14 17:32 ` [PATCH v2 0/6] Remove "old" built-in function infrastructure Bill Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211207010951.GR614@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).