From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C27FB3858C39 for ; Thu, 9 Dec 2021 12:34:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C27FB3858C39 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-510-mG3FoaxLPoOIT3kDkRSETQ-1; Thu, 09 Dec 2021 07:34:37 -0500 X-MC-Unique: mG3FoaxLPoOIT3kDkRSETQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1138F192D786; Thu, 9 Dec 2021 12:34:36 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.194.188]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9DD3F1010426; Thu, 9 Dec 2021 12:34:35 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 1B9CYWY71546404 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 9 Dec 2021 13:34:32 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 1B9CYVLs1546403; Thu, 9 Dec 2021 13:34:31 +0100 Date: Thu, 9 Dec 2021 13:34:31 +0100 From: Jakub Jelinek To: Andrew Stubbs Cc: "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH] OpenMP: Ensure that offloaded variables are public Message-ID: <20211209123431.GG2646553@tucnak> Reply-To: Jakub Jelinek References: <6843a549-0d4d-0ca7-ae34-929a15e0fa98@codesourcery.com> <20211130162449.GP2646553@tucnak> <20211130165459.GQ2646553@tucnak> <20211202125858.GG2646553@tucnak> <03912ac5-e368-21b1-beb0-aa4fb456ff0b@codesourcery.com> <862dbe15-4dac-c027-6c4e-e1fa2c9e334a@codesourcery.com> <20211202164347.GK2646553@tucnak> <3cdb7713-3e1d-85e9-f923-2e771d75a3cb@codesourcery.com> MIME-Version: 1.0 In-Reply-To: <3cdb7713-3e1d-85e9-f923-2e771d75a3cb@codesourcery.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Dec 2021 12:34:43 -0000 On Thu, Dec 09, 2021 at 11:41:46AM +0000, Andrew Stubbs wrote: > gcc/ChangeLog: > > * config/gcn/mkoffload.c (process_asm): Process the variable table > completely differently. > (process_obj): Encode the varaible data differently. > > include/ChangeLog: > > * gomp-constants.h (GOMP_VERSION_GCN): Bump. > > libgomp/ChangeLog: > > * plugin/plugin-gcn.c (struct gcn_image_desc): Remove global_variables. > (GOMP_OFFLOAD_load_image): Locate the offload variables via the > table, not individual symbols. I'm very happy this worked out. LGTM, but sure, you can approve it yourself. Jakub