From: Jakub Jelinek <jakub@redhat.com>
To: Joel Hutton <Joel.Hutton@arm.com>
Cc: Richard Biener <richard.guenther@gmail.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Tobias Burnus <tobias@codesourcery.com>,
Richard Sandiford <Richard.Sandiford@arm.com>,
Richard Biener <rguenther@suse.de>
Subject: Re: GCC 11 backport does not build (no "directly_supported_p") - was: Re: pr103523: Check for PLUS/MINUS support
Date: Tue, 14 Dec 2021 11:57:06 +0100 [thread overview]
Message-ID: <20211214105706.GV2646553@tucnak> (raw)
In-Reply-To: <DB9PR08MB660385A22369EECD48D50A3CF5759@DB9PR08MB6603.eurprd08.prod.outlook.com>
On Tue, Dec 14, 2021 at 10:46:39AM +0000, Joel Hutton wrote:
> > + if (ot_plus == unknown_optab
> > + || ot_minus == unknown_optab
> > + || optab_handler (ot_minus, TYPE_MODE (step_vectype)) ==
> > CODE_FOR_nothing
> > + || optab_handler (ot_plus, TYPE_MODE (step_vectype)) ==
> > + CODE_FOR_nothing)
> > return false;
> >
> > Won't optab_handler just return CODE_FOR_nothing for unknown_optab?
>
> I was taking the check used in directly_supported_p
>
> return (optab != unknown_optab$
> && optab_handler (optab, TYPE_MODE (type)) != CODE_FOR_nothing);$
>
> > Anyway, I think best would be to write it as:
> > if (!target_supports_op_p (step_vectype, PLUS_EXPR, optab_default)
> > || !target_supports_op_p (step_vectype, MINUS_EXPR, optab_default))
> > return false;
> Looks good to me.
>
> Patch attached.
>
> Tests running on gcc-11 on aarch64.
>
> Ok for 11 once tests come back?
Yes, thanks.
Jakub
prev parent reply other threads:[~2021-12-14 10:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 10:02 Joel Hutton
2021-12-10 10:22 ` Richard Sandiford
2021-12-10 13:24 ` Joel Hutton
2021-12-10 18:33 ` Richard Sandiford
2021-12-13 14:27 ` GCC 11 backport does not build (no "directly_supported_p") - was: " Tobias Burnus
2021-12-13 14:47 ` Richard Biener
2021-12-13 15:02 ` Joel Hutton
2021-12-14 9:37 ` Joel Hutton
2021-12-14 9:53 ` Jakub Jelinek
2021-12-14 10:46 ` Joel Hutton
2021-12-14 10:57 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211214105706.GV2646553@tucnak \
--to=jakub@redhat.com \
--cc=Joel.Hutton@arm.com \
--cc=Richard.Sandiford@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
--cc=richard.guenther@gmail.com \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).