From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 304933858D28 for ; Wed, 15 Dec 2021 15:24:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 304933858D28 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-359-ogoo_POtNFuXMWQR4vfYWw-1; Wed, 15 Dec 2021 10:24:06 -0500 X-MC-Unique: ogoo_POtNFuXMWQR4vfYWw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4E5FD802921; Wed, 15 Dec 2021 15:24:05 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.2.16.169]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BF72B101E819; Wed, 15 Dec 2021 15:24:04 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 1BFFO2iU2509290 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 15 Dec 2021 16:24:02 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 1BFFO1De2509289; Wed, 15 Dec 2021 16:24:01 +0100 Date: Wed, 15 Dec 2021 16:24:01 +0100 From: Jakub Jelinek To: Siddhesh Poyarekar Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH v4 2/6] __builtin_dynamic_object_size: Recognize builtin Message-ID: <20211215152401.GK2646553@tucnak> Reply-To: Jakub Jelinek References: <20211109190137.1107736-1-siddhesh@gotplt.org> <20211201142757.4086840-1-siddhesh@gotplt.org> <20211201142757.4086840-3-siddhesh@gotplt.org> MIME-Version: 1.0 In-Reply-To: <20211201142757.4086840-3-siddhesh@gotplt.org> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Dec 2021 15:24:13 -0000 On Wed, Dec 01, 2021 at 07:57:53PM +0530, Siddhesh Poyarekar wrote: > Recognize the __builtin_dynamic_object_size builtin and add paths in the > object size path to deal with it, but treat it like > __builtin_object_size for now. Also add tests to provide the same > testing coverage for the new builtin name. > > gcc/ChangeLog: > > * builtins.def (BUILT_IN_DYNAMIC_OBJECT_SIZE): New builtin. > * tree-object-size.h: Move object size type bits enum from > tree-object-size.c and add new value OST_DYNAMIC. > * builtins.c (expand_builtin, fold_builtin_2): Handle it. > (fold_builtin_object_size): Handle new builtin and adjust for > change to compute_builtin_object_size. > * tree-object-size.c: Include builtins.h. > (compute_builtin_object_size): Adjust. > (early_object_sizes_execute_one, > dynamic_object_sizes_execute_one): New functions. > (object_sizes_execute): Rename insert_min_max_p argument to > early. Handle BUILT_IN_DYNAMIC_OBJECT_SIZE and call the new > functions. > doc/extend.texi (__builtin_dynamic_object_size): Document new > builtin. > > gcc/testsuite/ChangeLog: > > * g++.dg/ext/builtin-dynamic-object-size1.C: New test. > * g++.dg/ext/builtin-dynamic-object-size2.C: Likewise. > * gcc.dg/builtin-dynamic-alloc-size.c: Likewise. > * gcc.dg/builtin-dynamic-object-size-1.c: Likewise. > * gcc.dg/builtin-dynamic-object-size-10.c: Likewise. > * gcc.dg/builtin-dynamic-object-size-11.c: Likewise. > * gcc.dg/builtin-dynamic-object-size-12.c: Likewise. > * gcc.dg/builtin-dynamic-object-size-13.c: Likewise. > * gcc.dg/builtin-dynamic-object-size-14.c: Likewise. > * gcc.dg/builtin-dynamic-object-size-15.c: Likewise. > * gcc.dg/builtin-dynamic-object-size-16.c: Likewise. > * gcc.dg/builtin-dynamic-object-size-17.c: Likewise. > * gcc.dg/builtin-dynamic-object-size-18.c: Likewise. > * gcc.dg/builtin-dynamic-object-size-19.c: Likewise. > * gcc.dg/builtin-dynamic-object-size-2.c: Likewise. > * gcc.dg/builtin-dynamic-object-size-3.c: Likewise. > * gcc.dg/builtin-dynamic-object-size-4.c: Likewise. > * gcc.dg/builtin-dynamic-object-size-5.c: Likewise. > * gcc.dg/builtin-dynamic-object-size-6.c: Likewise. > * gcc.dg/builtin-dynamic-object-size-7.c: Likewise. > * gcc.dg/builtin-dynamic-object-size-8.c: Likewise. > * gcc.dg/builtin-dynamic-object-size-9.c: Likewise. > * gcc.dg/builtin-object-size-16.c: Adjust to allow inclusion > from builtin-dynamic-object-size-16.c. > * gcc.dg/builtin-object-size-17.c: Likewise. Ok, thanks. Jakub