From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id EA8483858D28 for ; Wed, 15 Dec 2021 18:42:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EA8483858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 1BFIfeVL001839; Wed, 15 Dec 2021 12:41:40 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 1BFIfdRn001838; Wed, 15 Dec 2021 12:41:39 -0600 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Wed, 15 Dec 2021 12:41:39 -0600 From: Segher Boessenkool To: Bill Schmidt Cc: David Edelsohn , GCC Patches Subject: Re: [PATCH] rs6000: __builtin_darn[_raw] should be in [power9-64] (PR103624) Message-ID: <20211215184139.GN614@gate.crashing.org> References: <21f6c411-8aed-6042-2e76-5649ac95d259@linux.ibm.com> <20211213165459.GF614@gate.crashing.org> <6d9f439c-c8a7-605d-e494-b20125837355@linux.ibm.com> <20211214002208.GH614@gate.crashing.org> <1e31830f-073f-6f61-ef3b-54b384b52baf@linux.ibm.com> <20211215022352.GK614@gate.crashing.org> <76f4cb24-dba5-2869-7d3a-141bcc1507c6@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <76f4cb24-dba5-2869-7d3a-141bcc1507c6@linux.ibm.com> User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Dec 2021 18:42:42 -0000 On Wed, Dec 15, 2021 at 08:00:02AM -0600, Bill Schmidt wrote: > > No, all builtins should work in either mode, and always return long. > > If the patterns are broken, the *patterns* should be fixed :-) > > OK, thanks! This is much clearer now. > > I've opened an internal issue about the deficiencies of the darn patterns and > their associated built-ins. In response to PR103624, I would like to start > with the existing patch to ensure the new support mirrors what we had before, > so we have that as a baseline. We can then move on to fixing the larger > set of problems. Is that a reasonable plan? It is much more work than doing it correct in the first place. I'll do the RTL side, if you want? Segher